web-angular: support running component tests in the browser #447
Conversation
| <!DOCTYPE html> | ||
| <html lang="en"> | ||
|
|
||
| <head> |
There was a problem hiding this comment.
This file isn't needed – unless you're doing something special.
pkg/test will generate it automatically...
...unless I'm missing something
There was a problem hiding this comment.
W/o this file I can't get the angular_test-based tests to run (I'm not saying that it is impossible, just that I don't know how).
I haven't run tests in this manner very much. I based the assumption that such a file was needed by looking at @matanlurey's angular_test demo app. In particular see the test folder.
I'll let @matanlurey comment.
cc @kwalrath
There was a problem hiding this comment.
Ah...maybe it's angular-test specific.
...ah! Or it's pub-serve specific. That's it, I bet!
chalin
force-pushed
the
chalin-add-web-ng-app-test-0914
branch
from
ae16e8c
to
4f1b4cd
Compare
chalin
force-pushed
the
chalin-add-web-ng-app-test-0914
branch
from
4f1b4cd
to
8f47657
Compare
|
What's the status of this PR, @chalin? Are we still waiting for feedback from @matanlurey? If so, I can bug him... |
|
We can't even run our own tests yet until @alorenzen and friends get it working. So the answer is... TBD. |
|
Closing this PR. We'll address this feature under Angular 5. |
Fixes #445
I've tested this and it seem to work. I.e., the framework reports that test pass, even if a "Bad state" exception is thrown (angulardart/angular#631).