Merge pull request #94 from darrenburns/upgrade-textual

Upgrade textual

pyproject.toml

@@ -15,7 +15,7 @@ dependencies = [
     "pyyaml==6.0.1",
     "pydantic-settings==2.3.4",
     "python-dotenv==1.0.1",
-    "textual[syntax]==0.76.0",
+    "textual[syntax]==0.77.0",
     "textual-autocomplete==3.0.0a9",
 ]
 readme = "README.md"

requirements-dev.lock

@@ -159,7 +159,7 @@ sniffio==1.3.1
     # via httpx
 syrupy==4.6.1
     # via pytest-textual-snapshot
-textual==0.76.0
+textual==0.77.0
     # via posting
     # via pytest-textual-snapshot
     # via textual-autocomplete

requirements.lock

@@ -64,7 +64,7 @@ rich==13.7.1
 sniffio==1.3.1
     # via anyio
     # via httpx
-textual==0.76.0
+textual==0.77.0
     # via posting
     # via textual-autocomplete
 textual-autocomplete==3.0.0a9

src/posting/app.py

@@ -7,6 +7,7 @@
 from textual.command import CommandPalette
 from textual.css.query import NoMatches
 from textual.events import Click
+from textual.keys import format_key
 from textual.reactive import Reactive, reactive
 from textual.app import App, ComposeResult
 from textual.binding import Binding
@@ -170,7 +171,7 @@ def compose(self) -> ComposeResult:
             yield CollectionBrowser(collection=self.collection)
             yield RequestEditor()
             yield ResponseArea()
-        yield Footer()
+        yield Footer(show_command_palette=False)
 
     async def send_request(self) -> None:
         self.url_bar.clear_events()

src/posting/commands.py

@@ -11,13 +11,13 @@ class PostingProvider(Provider):
     @property
     def commands(
         self,
-    ) -> tuple[tuple[str, IgnoreReturnCallbackType, str], ...]:
+    ) -> tuple[tuple[str, IgnoreReturnCallbackType, str, bool], ...]:
         app = self.posting
         screen = self.screen
 
-        commands_to_show: list[tuple[str, IgnoreReturnCallbackType, str]] = [
+        commands_to_show: list[tuple[str, IgnoreReturnCallbackType, str, bool]] = [
             *self.get_theme_commands(),
-            ("app: quit", app.action_quit, "Quit Posting"),
+            ("app: quit", app.action_quit, "Quit Posting", True),
         ]
 
         from posting.app import MainScreen
@@ -30,6 +30,7 @@ def commands(
                         "layout: vertical",
                         partial(app.command_layout, "vertical"),
                         "Change layout to vertical",
+                        True,
                     ),
                 )
             elif screen.layout == "vertical":
@@ -38,6 +39,7 @@ def commands(
                         "layout: horizontal",
                         partial(app.command_layout, "horizontal"),
                         "Change layout to horizontal",
+                        True,
                     ),
                 )
 
@@ -48,16 +50,19 @@ def commands(
                 "view: reset",
                 partial(screen.maximize_section, None),
                 "Reset section sizes to default",
+                True,
             )
             expand_request_command = (
                 "view: expand request",
                 partial(screen.maximize_section, "request"),
                 "Expand the request section",
+                True,
             )
             expand_response_command = (
                 "view: expand response",
                 partial(screen.maximize_section, "response"),
                 "Expand the response section",
+                True,
             )
             if maximized == "request":
                 commands_to_show.extend([reset_command, expand_response_command])
@@ -73,6 +78,7 @@ def commands(
                     "view: toggle collection browser",
                     screen.action_toggle_collection_browser,
                     "Toggle the collection browser",
+                    True,
                 ),
             )
 
@@ -84,12 +90,13 @@ async def discover(self) -> Hits:
         Yields:
             Commands that can be discovered.
         """
-        for name, runnable, help_text in self.commands:
-            yield DiscoveryHit(
-                name,
-                runnable,
-                help=help_text,
-            )
+        for name, runnable, help_text, show_discovery in self.commands:
+            if show_discovery:
+                yield DiscoveryHit(
+                    name,
+                    runnable,
+                    help=help_text,
+                )
 
     async def search(self, query: str) -> Hits:
         """Handle a request to search for commands that match the query.
@@ -101,7 +108,7 @@ async def search(self, query: str) -> Hits:
             Command hits for use in the command palette.
         """
         matcher = self.matcher(query)
-        for name, runnable, help_text in self.commands:
+        for name, runnable, help_text, _ in self.commands:
             if (match := matcher.match(name)) > 0:
                 yield Hit(
                     match,
@@ -112,17 +119,18 @@ async def search(self, query: str) -> Hits:
 
     def get_theme_commands(
         self,
-    ) -> tuple[tuple[str, IgnoreReturnCallbackType, str], ...]:
+    ) -> tuple[tuple[str, IgnoreReturnCallbackType, str, bool], ...]:
         posting = self.posting
         return tuple(self.get_theme_command(theme) for theme in posting.themes)
 
     def get_theme_command(
         self, theme_name: str
-    ) -> tuple[str, IgnoreReturnCallbackType, str]:
+    ) -> tuple[str, IgnoreReturnCallbackType, str, bool]:
         return (
             f"theme: {theme_name}",
             partial(self.posting.command_theme, theme_name),
             f"Set the theme to {theme_name}",
+            False,
         )
 
     @property

src/posting/help_screen.py

@@ -181,7 +181,7 @@ def compose(self) -> ComposeResult:
                             ", ".join(
                                 binding.key_display
                                 if binding.key_display
-                                else self.app.get_key_display(key)
+                                else self.app.get_key_display(binding)
                                 for binding in bindings
                             ),
                             style="bold",

src/posting/widgets/collection/new_request_modal.py

@@ -152,7 +152,7 @@ def compose(self) -> ComposeResult:
 
             yield Button.success("Create request", id="create-button")
 
-        yield Footer()
+        yield Footer(show_command_palette=False)
 
     def action_close_screen(self) -> None:
         self.dismiss(None)