Skip to content

Commit

Permalink
Do not use default setting when value is false
Browse files Browse the repository at this point in the history
fix brave#4903

Auditors: @bbondy

Test Plan:
1. Turn on/off "Always show the URL bar" in about:preferences#general
2. The title mode should work as expected
  • Loading branch information
darkdh committed Oct 18, 2016
1 parent 78634f6 commit 1092758
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion js/settings.js
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ const resolveValue = (settingKey, settingsCollection) => {

module.exports.getSetting = (settingKey, settingsCollection) => {
const setting = resolveValue(settingKey, settingsCollection)
if (setting) return setting
if (typeof setting !== 'undefined') return setting
return getDefaultSetting(settingKey, settingsCollection)
}

Expand Down

0 comments on commit 1092758

Please sign in to comment.