Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Errors reported have non-idiomatic naming #2

Closed
billstar opened this issue Apr 10, 2014 · 2 comments
Closed

Errors reported have non-idiomatic naming #2

billstar opened this issue Apr 10, 2014 · 2 comments

Comments

@billstar
Copy link

The global error vars, NilArgumentsErr, DifferentArgumentsTypesErr and NotSupportedErr should probably have names like ErrNilArguments, etc. This style of error naming is more consistent with other golang code.
@darccio
Copy link
Owner

darccio commented Apr 21, 2014

Cool! I'll check it as soon as possible but I'm running for European Parliament and I won't have too much free time until 25th March. Anyway, I'll do my best!

darccio added a commit that referenced this issue Jun 25, 2014
@darccio
Issue #2 fixed: errors now have idiomatic naming.
6af8196
@darccio
Copy link
Owner

darccio commented Jun 25, 2014

Fixed. Thanks for the tip!

@darccio darccio closed this as completed Jun 25, 2014
vsemichev added a commit to vsemichev/mergo that referenced this issue Jun 5, 2024
@vsemichev
fixes issue darccio#187. attempt darccio#2
a13a117
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@darccio @billstar