Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating the workflow console app example program to allow for CTRL+C to properly terminate the program, and Readme updates #1194

Merged
merged 2 commits into from
Nov 29, 2023

Conversation

RyanLettieri
Copy link
Contributor

Description

Added in logic to properly catch a CTRL+C termination input from the user to shutdown the workflow console app example.

Updated Readme

Issue reference

This PR will close: #[1189] #[1191]

**Note that the issue of 1189 will not fully be resolved until microsoft/durabletask-dotnet#249 is resolved.

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com>
@RyanLettieri RyanLettieri requested review from a team as code owners November 29, 2023 18:53
Copy link

codecov bot commented Nov 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1cb0052) 66.53% compared to head (15aead9) 66.53%.
Report is 1 commits behind head on master.

❗ Current head 15aead9 differs from pull request most recent head 2d04263. Consider uploading reports for the commit 2d04263 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1194   +/-   ##
=======================================
  Coverage   66.53%   66.53%           
=======================================
  Files         171      171           
  Lines        5752     5752           
  Branches      626      626           
=======================================
  Hits         3827     3827           
  Misses       1776     1776           
  Partials      149      149           
Flag Coverage Δ
net6 66.52% <ø> (ø)
net7 66.52% <ø> (ø)
net8 66.52% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants