Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNS/SQS contention #3863

Merged
merged 3 commits into from
Nov 21, 2023
Merged

SNS/SQS contention #3863

merged 3 commits into from
Nov 21, 2023

Conversation

amimimor
Copy link
Contributor

@amimimor amimimor commented Nov 12, 2023

Thank you for helping make the Dapr documentation better!

Please follow this checklist before submitting:

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Read the contribution guide
  • Commands include options for Linux, MacOS, and Windows within codetabs
  • New file and folder names are globally unique
  • Page references use shortcodes instead of markdown or URL links
  • Images use HTML style and have alternative text
  • Places where multiple code/command options are given have codetabs

In addition, please fill out the following to help reviewers understand this pull request:

Description

The PR adds explanation for the limitations of the component, as with any SQS consumer, handling messages from SQS originating from SNS topics the component has no handlers for

Issue reference

#3820

Signed-off-by: Amit Mor <amit.mor@hotmail.com>
Signed-off-by: Amit Mor <amitm@at-bay.com>
@amimimor amimimor requested review from a team as code owners November 12, 2023 19:53
Signed-off-by: Amit Mor <amit.mor@hotmail.com>
Signed-off-by: Amit Mor <amitm@at-bay.com>
Copy link
Collaborator

@hhunter-ms hhunter-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quick review for readability

Signed-off-by: Amit Mor <amit.mor@hotmail.com>
Signed-off-by: Amit Mor <amitm@at-bay.com>
Copy link

Stale PR, paging all reviewers

@github-actions github-actions bot added the stale label Nov 20, 2023
Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@msfussell msfussell removed the stale label Nov 20, 2023
@msfussell msfussell added this to the 1.13 milestone Nov 20, 2023
@hhunter-ms hhunter-ms merged commit 2842655 into dapr:v1.13 Nov 21, 2023
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants