Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] First take on adding namespace support to vault. Aim to close #2806 #2808

Closed
wants to merge 2 commits into from

Conversation

tmacam
Copy link
Contributor

@tmacam tmacam commented Apr 25, 2023

Description

Please explain the changes you've made

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #[issue number]

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]

@tmacam tmacam changed the title First take on adding namespace support to vault. Aim to close #2806 [WIP] First take on adding namespace support to vault. Aim to close #2806 Apr 25, 2023
Aim to close dapr#2806

Signed-off-by: Tiago Alves Macambira <tmacam@burocrata.org>
@github-actions
Copy link

github-actions bot commented Jul 1, 2023

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@github-actions github-actions bot added the stale label Jul 1, 2023
@yaron2
Copy link
Member

yaron2 commented Jul 2, 2023

@tmacam are you planning to finishing this for 1.12? What else is needed here?

@github-actions github-actions bot removed the stale label Jul 2, 2023
@tmacam
Copy link
Contributor Author

tmacam commented Jul 5, 2023

@tmacam are you planning to finishing this for 1.12? What else is needed here?

No. As I mentioned on my comment on #2806 (comment) there is a way to use enginePath to provide the same functionality as namespaces with the advantage we can test enginePath with open-source Vault whereas namespace isn't testable with open-source Vault. Let me drop this PR.

@tmacam tmacam closed this Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants