Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

maintain dao schemes history #496

Closed
orenyodfat opened this issue Mar 14, 2020 · 0 comments · Fixed by #497
Closed

maintain dao schemes history #496

orenyodfat opened this issue Mar 14, 2020 · 0 comments · Fixed by #497
Assignees
@ben-kaufman

Comments

@orenyodfat
Copy link
Contributor

  • do not delete ControllerSchemes upon unregisterScheme events.
  • add isRegister flag to controllerScheme
    this will allow alchemy to show proposals history even if scheme is unregister.
@orenyodfat orenyodfat mentioned this issue Mar 14, 2020
Closed
ben-kaufman added a commit that referenced this issue Mar 15, 2020
@ben-kaufman
Fix #496
40e8a6d
@ben-kaufman ben-kaufman mentioned this issue Mar 15, 2020
Merged
ben-kaufman added a commit that referenced this issue Mar 15, 2020
@ben-kaufman
Fix #496 (#497)
dbcbd3c 
* Fix #496

* SchemRegistrar test

* bump version

* Bump version to 39

* version fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ben-kaufman ben-kaufman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #496 daostack/subgraph
2 participants
@orenyodfat @ben-kaufman