Fix competition issue (#464)

* Fix competition issue * bump version
daostack · Feb 4, 2020 · 5141403 · 5141403
1 parent 7a1e866
commit 5141403
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@daostack/subgraph",
-  "version": "0.0.37-2",
+  "version": "0.0.37-3",
   "author": "DAOstack (https://www.daostack.io)",
   "license": "GPL-3.0",
   "description": "A caching layer for daostack using The Graph",

diff --git a/src/mappings/Competition/mapping.ts b/src/mappings/Competition/mapping.ts
@@ -156,23 +156,23 @@ export function handleNewVote(event: NewVote): void {
         return 1;
       }
     });
-    let lastTotalVotes = BigInt.fromI32(0);
+    let lastTotalWinnerVotes = BigInt.fromI32(0);
     let idx = BigInt.fromI32(0);
     for (let i = 0; i < suggestions.length; i++) {
       let competitionSuggestion = CompetitionSuggestion.load(suggestions[i] as string);
-      if (lastTotalVotes.gt(competitionSuggestion.totalVotes)) {
+      if (lastTotalWinnerVotes.gt(competitionSuggestion.totalVotes)) {
         idx = idx.plus(BigInt.fromI32(1));
       }
-      if ((lastTotalVotes.notEqual(competitionSuggestion.totalVotes) &&
+      if ((lastTotalWinnerVotes.notEqual(competitionSuggestion.totalVotes) &&
         idx >= competitionProposal.numberOfWinners) ||
         competitionSuggestion.totalVotes.equals(BigInt.fromI32(0))) {
         competitionSuggestion.positionInWinnerList = null;
       } else {
         competitionSuggestion.positionInWinnerList = idx;
         winningSuggestions.push(competitionSuggestion.id as string);
+        lastTotalWinnerVotes = competitionSuggestion.totalVotes;
       }
       competitionSuggestion.save();
-      lastTotalVotes = competitionSuggestion.totalVotes;
     }
     competitionProposal.winningSuggestions = winningSuggestions;
     competitionProposal.save();