DAOS-7198 control: Use join request context instead of timeout #5398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the MS joinLoop, a short timeout was used to avoid blocking the loop if a join request handler exited before receiving the batched join response. Rather than relying on an arbitrary timeout value, we should instead pass in the join request's context so that we can correctly wait for the handler to receive the request or for the context to be canceled. Either way, it won't block the join loop indefinitely. Master-PR: #5380 Signed-off-by: Michael MacDonald <mjmac.macdonald@intel.com>
daosbuild1
reviewed
Apr 9, 2021
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the MS joinLoop, a short timeout was used to avoid blocking
the loop if a join request handler exited before receiving the
batched join response. Rather than relying on an arbitrary
timeout value, we should instead pass in the join request's
context so that we can correctly wait for the handler to receive
the request or for the context to be canceled. Either way, it
won't block the join loop indefinitely.
Master-PR: #5380