Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-16276 doc: Address engine unavailability #15456

Merged
merged 2 commits into from
Nov 12, 2024
Merged

Conversation

liw
Copy link
Contributor

@liw liw commented Nov 6, 2024

Add a section on handling unavailable engines.

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

Copy link

github-actions bot commented Nov 6, 2024

Ticket title is 'Document how to bring DAOS cluster online after many servers failed'
Status is 'In Progress'
https://daosio.atlassian.net/browse/DAOS-16276

@liw liw marked this pull request as ready for review November 6, 2024 05:36
@liw liw requested a review from a team as a code owner November 6, 2024 05:36
Add a section on handling unavailable engines.

Signed-off-by: Li Wei <wei.g.li@intel.com>
Required-githooks: true
@liw liw force-pushed the liw/doc-recovery branch from 9f6dd50 to cda7fd0 Compare November 6, 2024 05:49
@liw
Copy link
Contributor Author

liw commented Nov 6, 2024

Sorry, a minor change: Added "that remain" at the end of a paragraph.

@@ -554,6 +554,21 @@ To resolve the issue:

Alternately, the administrator may erase and re-format the DAOS system to start over fresh using the new addresses.

### Engines become unavailable

Engines may become unavailable due to server power losses and reboots, network switch failures, etc. After staying unavailable for a certain period of time, these engines may become "excluded" or "errored" in `dmg system query` output. Once the states of all engines stablize (see [`CRT_EVENT_DELAY`](env_variables.md)), each pool will check whether there is enough redundancy (see [Pool RF](pool_operations.md#pool-redundancy-factor)) to tolerate the unavailability of the "excluded" or "errored" engines. If there is enough redundancy, these engines will be excluded from the pool ("disabled ranks" in `dmg pool query --health-only` output); otherwise, the pool will perform no exclusion and may become temporarily unavailable. Similarly, when engines become available, whenever the states of all engines stablize, each pool will perform the aforementioned check for any unavailable engines that remain.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggest adding to the end of the sentence
... "and may become temporarily unavailable (as seen by timeouts of certain commands, for example, dmg pool query and dmg pool list)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I asked myself this too when writing these words. Added.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also fixed "stablize" -> "stabilize".

Signed-off-by: Li Wei <wei.g.li@intel.com>
Required-githooks: true
@liw liw requested a review from kccain November 7, 2024 00:42
@liw liw requested a review from a team November 7, 2024 23:53
@daltonbohning daltonbohning merged commit 0b6ff63 into master Nov 12, 2024
35 of 36 checks passed
@daltonbohning daltonbohning deleted the liw/doc-recovery branch November 12, 2024 22:29
liw added a commit that referenced this pull request Nov 13, 2024
Add a section on handling unavailable engines.

Signed-off-by: Li Wei <wei.g.li@intel.com>
Required-githooks: true
daltonbohning pushed a commit that referenced this pull request Dec 12, 2024
Add a section on handling unavailable engines.

Signed-off-by: Li Wei <wei.g.li@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants