Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-16713 vos: initialize checkpoint stats #15454

Merged
merged 2 commits into from
Nov 12, 2024
Merged

DAOS-16713 vos: initialize checkpoint stats #15454

merged 2 commits into from
Nov 12, 2024

Conversation

NiuYawei
Copy link
Contributor

@NiuYawei NiuYawei commented Nov 6, 2024

Initialize checkpoint stats to zero.

Skip-func-hw-test-medium-md-on-ssd: false
Skip-func-hw-test-large-md-on-ssd: false

Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

Initialize checkpoint stats to zero.

Skip-func-hw-test-medium-md-on-ssd: false
Skip-func-hw-test-large-md-on-ssd: false

Required-githooks: true

Signed-off-by: Niu Yawei <yawei.niu@intel.com>
@NiuYawei NiuYawei requested review from a team as code owners November 6, 2024 02:15
@NiuYawei NiuYawei requested a review from tanabarr November 6, 2024 02:16
Copy link

github-actions bot commented Nov 6, 2024

Ticket title is 'telemetry/wal_metrics.py:WalMetrics.test_wal_checkpoint_metrics- json: unsupported value: NaN'
Status is 'In Review'
Labels: 'daily_test,md_on_ssd2,ci_master_daily'
https://daosio.atlassian.net/browse/DAOS-16713

Copy link
Contributor

@tanabarr tanabarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this need to run with Features: telemetry ?

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15454/1/execution/node/1641/log

Test-tag: pr daily_regression hw,medium
Skip-func-hw-test-medium-md-on-ssd: false
Skip-func-hw-test-large-md-on-ssd: false

Required-githooks: true

Signed-off-by: Niu Yawei <yawei.niu@intel.com>
@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Large completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15454/2/execution/node/1466/log

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Large MD on SSD completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15454/2/execution/node/1450/log

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium Verbs Provider completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15454/2/execution/node/1703/log

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15454/2/execution/node/1657/log

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium MD on SSD completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15454/2/execution/node/1641/log

@NiuYawei NiuYawei requested a review from a team November 11, 2024 00:37
@NiuYawei
Copy link
Contributor Author

@daos-stack/daos-gatekeeper , the test showed that the issue is fixed by the patch. These CI failures are from daily tests (The issue was on md-on-ssd daily, so I enabled daily test for this PR), let's force land it.

@gnailzenh gnailzenh merged commit d820b71 into master Nov 12, 2024
48 of 56 checks passed
@gnailzenh gnailzenh deleted the niu/DAOS-16713 branch November 12, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

6 participants