DAOS-15429 test: Fix racy unit test #15384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous change to this test introduced a race in the context cancellation test case. Safer to just select on the context done channel or the time after channel. Required-githooks: true Change-Id: Idbf4fa69ece13136b5c392a0bf1760c448cc47a0 Signed-off-by: Michael MacDonald <mjmac@google.com>
|
Ticket title is 'Control plane unit tests are broken with gRPC 1.56' |
pavelgritsai
approved these changes
Oct 25, 2024
jolivier23
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous change to this test introduced a race in the
context cancellation test case. Safer to just select on
the context done channel or the time after channel.
Required-githooks: true
Change-Id: Idbf4fa69ece13136b5c392a0bf1760c448cc47a0
Signed-off-by: Michael MacDonald mjmac@google.com