Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-16639 object: fix assertion #15329

Merged
merged 5 commits into from
Nov 4, 2024
Merged

DAOS-16639 object: fix assertion #15329

merged 5 commits into from
Nov 4, 2024

Conversation

wangdi1
Copy link
Contributor

@wangdi1 wangdi1 commented Oct 16, 2024

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@wangdi1
DAOS-16639 object: fix assertion
39b32f7 
Invalid hole extent might be left by process_hole_ult(),
so let's skip it.

Signed-off-by: Di Wang <ddiwang@google.com>
@wangdi1
Merge branch 'master' into daos-16639
a8b8b3a
@wangdi1
Merge branch 'master' into daos-16639
9ed40c0
@wangdi1
DAOS-16639 object: fix format
8e86cf6 
fix format

Features: ec
Required-githooks: true

Signed-off-by: Di Wang <ddiwang@google.com>
@wangdi1 wangdi1 requested review from a team as code owners October 16, 2024 04:03
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 16, 2024 •
edited
Loading

Ticket title is 'agg_diff_preprocess() Assertion '!extent->ae_hole' failed'
Status is 'Open'
Labels: 'scrubbed_2.8'
https://daosio.atlassian.net/browse/DAOS-16639

@wangdi1 wangdi1 requested a review from jolivier23 October 16, 2024 04:04
@wangdi1 wangdi1 changed the title Wangdi/daos 16639 DAOS-16639 object: fix assertion Oct 16, 2024
@wangdi1 wangdi1 mentioned this pull request Oct 16, 2024
Closed
18 tasks
@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-15329/2/display/redirect

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Large completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15329/2/execution/node/1430/log

@liuxuezhao liuxuezhao requested a review from a team October 30, 2024 07:20
@jolivier23 jolivier23 merged commit c1ae651 into master Nov 4, 2024
53 of 54 checks passed
@jolivier23 jolivier23 deleted the wangdi/daos-16639 branch November 4, 2024 17:27
wangdi1 added a commit that referenced this pull request Nov 5, 2024
@wangdi1
DAOS-16639 object: fix assertion (#15329)
f61df03 
Invalid hole extent might be left by process_hole_ult(),
so let's skip it.

Signed-off-by: Di Wang <ddiwang@google.com>
wangdi1 added a commit that referenced this pull request Nov 10, 2024
@wangdi1
DAOS-16639 object: fix assertion (#15329)
37cf2ad 
Invalid hole extent might be left by process_hole_ult(),
so let's skip it.

Signed-off-by: Di Wang <ddiwang@google.com>
jolivier23 pushed a commit that referenced this pull request Nov 11, 2024
@wangdi1
DAOS-16639 object: fix assertion (#15329) (#15485)
401dcde 
Invalid hole extent might be left by process_hole_ult(),
so let's skip it.

Signed-off-by: Di Wang <ddiwang@google.com>
This was referenced Nov 13, 2024
Closed
Merged
Merged
This was referenced Nov 25, 2024
Closed
Merged
@mjmac mjmac mentioned this pull request Dec 2, 2024
Merged
wangdi1 added a commit that referenced this pull request Jan 3, 2025
@wangdi1
DAOS-16639 object: fix assertion (#15329)
782695e 
Invalid hole extent might be left by process_hole_ult(),
so let's skip it.

Signed-off-by: Di Wang <ddiwang@google.com>
gnailzenh pushed a commit that referenced this pull request Jan 10, 2025
@wangdi1
DAOS-16639 object: fix assertion (#15329) (#15681)
bd55fc4 
Invalid hole extent might be left by process_hole_ult(),
so let's skip it.

Signed-off-by: Di Wang <ddiwang@google.com>
@mjmac mjmac mentioned this pull request Jan 13, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jolivier23 jolivier23 jolivier23 approved these changes

@liuxuezhao liuxuezhao liuxuezhao approved these changes

@johannlombardi johannlombardi Awaiting requested review from johannlombardi

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wangdi1 @daosbuild1 @liuxuezhao @jolivier23