Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-10146 build: Support of GCP VMs with ansible ftest #15311

Merged
merged 1 commit into from
Oct 17, 2024
Merged

DAOS-10146 build: Support of GCP VMs with ansible ftest #15311

merged 1 commit into from
Oct 17, 2024

Conversation

knard38
Copy link
Contributor

@knard38 knard38 commented Oct 14, 2024

Description

Miscellaneous inmoprovements allowing to use ansible ftest deloyment script with GCP virtual machines.

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@kanard38
DAOS-10146 build: Support of GCP VMs with ansible ftest
42b27be 
Miscellaneous inmoprovements allowing to use ansible ftest deloyment
script with GCP virtual machines.

Required-githooks: true

Signed-off-by: Cedric Koch-Hofer <cedric.koch-hofer@intel.com>
@github-actions GitHub Actions
Copy link

Ticket title is 'Scripts to run avocado test from source tree'
Status is 'Resolved'
https://daosio.atlassian.net/browse/DAOS-10146

@knard38 knard38 marked this pull request as ready for review October 15, 2024 07:14
@knard38 knard38 requested a review from a team as a code owner October 15, 2024 07:14
@johannlombardi johannlombardi requested a review from a team October 15, 2024 13:35
@johannlombardi
Copy link
Contributor

Requesting landing to 2.8 since the code is isolated to the ansible script and this would allow us to run functional tests on GCP. Thanks Cedric!

0xE0F
0xE0F approved these changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@0xE0F 0xE0F left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, looks good to me.
Thank you!

@johannlombardi johannlombardi merged commit 59b5b54 into master Oct 17, 2024
55 checks passed
@johannlombardi johannlombardi deleted the ckochhof/dev/master/gcp_ftest branch October 17, 2024 12:22
@mjmac mjmac mentioned this pull request Nov 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johannlombardi johannlombardi johannlombardi approved these changes

@0xE0F 0xE0F 0xE0F approved these changes

@mjmac mjmac Awaiting requested review from mjmac

@jolivier23 jolivier23 Awaiting requested review from jolivier23

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@knard38 @johannlombardi @0xE0F @kanard38