Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-16509 test: replace IorTestBase.execute_cmd with run_remote (#15… #15250

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

daltonbohning
Copy link
Contributor

…070)

replace usage of IorTestBase.execute_cmd with run_remote

Test-tag: DfuseSpaceCheck DmvrPosixMetaEntry DmvrPosixSymlinks critical_integration SparseFile

Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@daltonbohning daltonbohning self-assigned this Oct 4, 2024
@daltonbohning daltonbohning added the clean-cherry-pick Cherry-pick from another branch that did not require additional edits label Oct 4, 2024
Copy link

github-actions bot commented Oct 4, 2024

Ticket title is 'ftest: remove IorTestBase.execute_cmd'
Status is 'Awaiting backport'
Job should run at elevated priority (1)
https://daosio.atlassian.net/browse/DAOS-16509

@github-actions github-actions bot added the priority Ticket has high priority (automatically managed) label Oct 4, 2024
@daltonbohning daltonbohning force-pushed the dbohning/daos-16509-2.6 branch from 59dcf4d to f1492c5 Compare October 9, 2024 14:35

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
)

replace usage of IorTestBase.execute_cmd with run_remote

Test-tag: DfuseSpaceCheck DmvrPosixMetaEntry DmvrPosixSymlinks critical_integration SparseFile
Skip-unit-tests: true
Skip-fault-injection-test: true

Required-githooks: true

Signed-off-by: Dalton Bohning <dalton.bohning@intel.com>
@daltonbohning daltonbohning force-pushed the dbohning/daos-16509-2.6 branch from f1492c5 to 2b41566 Compare October 9, 2024 17:30
@daltonbohning daltonbohning marked this pull request as ready for review October 10, 2024 16:05
@daltonbohning daltonbohning requested review from a team as code owners October 10, 2024 16:05
@daltonbohning daltonbohning requested a review from a team October 14, 2024 17:34
@daltonbohning daltonbohning added the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label Oct 14, 2024
@daltonbohning daltonbohning merged commit d85eb82 into release/2.6 Oct 14, 2024
44 checks passed
@daltonbohning daltonbohning deleted the dbohning/daos-16509-2.6 branch October 14, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clean-cherry-pick Cherry-pick from another branch that did not require additional edits forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. priority Ticket has high priority (automatically managed)
Development

Successfully merging this pull request may close these issues.

2 participants