Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-16614 build: Tag 2.6.1 rc2 #15170

Merged
merged 1 commit into from
Sep 21, 2024
Merged

DAOS-16614 build: Tag 2.6.1 rc2 #15170

merged 1 commit into from
Sep 21, 2024

Conversation

phender
Copy link
Contributor

@phender phender commented Sep 21, 2024

Tag second release candidate for 2.6.1.

Skip-func-test: true

Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@phender
DAOS-16614 build: Tag 2.6.1 rc2
cbfda2f 
Tag second release candidate for 2.6.1.

Skip-func-test: true

Required-githooks: true

Signed-off-by: Phil Henderson <phillip.henderson@intel.com>
@phender phender requested a review from a team as a code owner September 21, 2024 02:53
@github-actions GitHub Actions
Copy link

Ticket title is 'Build 2.6.1 RC2'
Status is 'In Progress'
Labels: 'pass,testp1,2.6.1rc2_val'
https://daosio.atlassian.net/browse/DAOS-16614

@phender
Copy link
Contributor Author

phender commented Sep 21, 2024

NLT timed out in both:

Seen before in previous release builds: https://daosio.atlassian.net/browse/DAOS-16153

@phender phender requested a review from a team September 21, 2024 18:54
@phender phender added the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label Sep 21, 2024
@phender phender merged commit 752837a into release/2.6 Sep 21, 2024
44 of 46 checks passed
@phender phender deleted the pahender/DAOS-16614 branch September 21, 2024 18:55
@jolivier23 jolivier23 mentioned this pull request Sep 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frostedcmos frostedcmos frostedcmos approved these changes

@Michael-Hennecke Michael-Hennecke Michael-Hennecke approved these changes

Assignees
No one assigned
Labels
forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@phender @frostedcmos @Michael-Hennecke