-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DAOS-16613 cq: update pylint to 3.3.0 #15165
Conversation
Ticket title is 'Update pylint to 3.3.0' |
update pylint to 3.3.0 Skip-build: true Required-githooks: true Signed-off-by: Dalton Bohning <dalton.bohning@intel.com>
6277e75
to
4f263bc
Compare
@@ -9,7 +9,8 @@ good-names=rc,ret,fd,kv,wf,rf | |||
|
|||
[MESSAGES CONTROL] | |||
disable=locally-disabled,locally-enabled,star-args,global-statement,bad-option-value, | |||
wrong-import-position,modified-iterating-list,duplicate-code,unspecified-encoding | |||
wrong-import-position,modified-iterating-list,duplicate-code,unspecified-encoding, | |||
too-many-positional-arguments |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have instances of too-many-positional-arguments
and if we do wouldn't they be real issues?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have a lot and most of them are in test code:
https://github.com/daos-stack/daos/actions/runs/10961121721/job/30437303670
It's not saying "you passed too many positional arguments", but rather "the function definition has too many positional arguments".
My intent here was to just stop the bleeding since it's existing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd missed that distinction, it's a code-smell/refactoring issue rather than a correctness issue.
Another way to silence this would be to set a max value in the config file at the current value we use to prevent further regressions and then ideally start re-working this code but given that it's test code I think what you've done here is fine.
update pylint to 3.3.0
Skip-build: true
Required-githooks: true
Before requesting gatekeeper:
Features:
(orTest-tag*
) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.Gatekeeper: