Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-16613 cq: update pylint to 3.3.0 #15165

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Conversation

daltonbohning
Copy link
Contributor

update pylint to 3.3.0

Skip-build: true

Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@daltonbohning daltonbohning self-assigned this Sep 20, 2024
Copy link

Ticket title is 'Update pylint to 3.3.0'
Status is 'In Progress'
https://daosio.atlassian.net/browse/DAOS-16613

update pylint to 3.3.0

Skip-build: true

Required-githooks: true

Signed-off-by: Dalton Bohning <dalton.bohning@intel.com>
@daltonbohning daltonbohning marked this pull request as ready for review September 20, 2024 15:51
@@ -9,7 +9,8 @@ good-names=rc,ret,fd,kv,wf,rf

[MESSAGES CONTROL]
disable=locally-disabled,locally-enabled,star-args,global-statement,bad-option-value,
wrong-import-position,modified-iterating-list,duplicate-code,unspecified-encoding
wrong-import-position,modified-iterating-list,duplicate-code,unspecified-encoding,
too-many-positional-arguments
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have instances of too-many-positional-arguments and if we do wouldn't they be real issues?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a lot and most of them are in test code:
https://github.com/daos-stack/daos/actions/runs/10961121721/job/30437303670

It's not saying "you passed too many positional arguments", but rather "the function definition has too many positional arguments".

My intent here was to just stop the bleeding since it's existing

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd missed that distinction, it's a code-smell/refactoring issue rather than a correctness issue.

Another way to silence this would be to set a max value in the config file at the current value we use to prevent further regressions and then ideally start re-working this code but given that it's test code I think what you've done here is fine.

@daltonbohning daltonbohning requested a review from a team September 24, 2024 19:27
@daltonbohning daltonbohning added the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label Sep 24, 2024
@daltonbohning daltonbohning merged commit ee09484 into master Sep 24, 2024
41 of 42 checks passed
@daltonbohning daltonbohning deleted the dbohning/daos-16613 branch September 24, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed.
Development

Successfully merging this pull request may close these issues.

3 participants