Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-16548 test: add ftest lint check for invalid test_ tag #15106

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

daltonbohning
Copy link
Contributor

Check that test_ tags are only used specifically for the one method they tag.

Skip-unit-tests: true
Skip-fault-injection-test: true

Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@daltonbohning daltonbohning self-assigned this Sep 9, 2024
Copy link

github-actions bot commented Sep 9, 2024

Ticket title is 'ftest linting: check that test_ tags are only used for the test method'
Status is 'In Progress'
https://daosio.atlassian.net/browse/DAOS-16548

@daosbuild1
Copy link
Collaborator

Test stage Functional on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15106/2/execution/node/799/log

@daltonbohning daltonbohning changed the title DAOS-16548 test: add ftest lint chang efor invalid test_ tag DAOS-16548 test: add ftest lint check for invalid test_ tag Sep 9, 2024
Check that test_ tags are only used specifically for the one method they
tag.

Test-tag: DaosCoreTest pr,vm
Skip-unit-tests: true
Skip-fault-injection-test: true

Required-githooks: true

Signed-off-by: Dalton Bohning <dalton.bohning@intel.com>
@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium Verbs Provider completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15106/4/execution/node/1011/log

@daltonbohning daltonbohning marked this pull request as ready for review September 10, 2024 15:05
@daltonbohning daltonbohning requested review from a team as code owners September 10, 2024 15:05
@daltonbohning
Copy link
Contributor Author

Test failure in https://build.hpdd.intel.com/blue/organizations/jenkins/daos-stack%2Fdaos/detail/PR-15106/4/tests
is unrelated since this PR just adds a lint check and does not affect individual test behavior.

@daltonbohning daltonbohning requested a review from a team September 17, 2024 23:03
@daltonbohning daltonbohning added the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label Sep 17, 2024
@daltonbohning
Copy link
Contributor Author

Failure in https://build.hpdd.intel.com/blue/organizations/jenkins/daos-stack%2Fdaos/detail/PR-15106/4/tests
test_daos_rebuild_simple - This PR doesn't affect that test, but I don't see an existing ticket

@daltonbohning daltonbohning merged commit 2197abf into master Sep 19, 2024
45 of 47 checks passed
@daltonbohning daltonbohning deleted the dbohning/daos-16548 branch September 19, 2024 19:11
daltonbohning added a commit that referenced this pull request Oct 9, 2024
Check that test_ tags are only used specifically for the one method they
tag.

Test-tag: DaosCoreTest pr,vm
Skip-unit-tests: true
Skip-fault-injection-test: true

Required-githooks: true

Signed-off-by: Dalton Bohning <dalton.bohning@intel.com>
daltonbohning added a commit that referenced this pull request Oct 10, 2024
…15285)

Check that test_ tags are only used specifically for the one method they
tag.

Signed-off-by: Dalton Bohning <dalton.bohning@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed.
Development

Successfully merging this pull request may close these issues.

4 participants