Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-16330 cart: Reduce error logs during timeouts (#14905) #14915

Merged
merged 2 commits into from
Aug 15, 2024

Conversation

frostedcmos
Copy link
Contributor

  • Reduce burst timeout error prints when multiple rpcs fail at the same time
  • Replace error prints with info during state processing, as error is already logged above
  • nuke 'No more free indices left' debug message
  • cleanup of startup logs

Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

- Reduce burst timeout error prints when multiple rpcs fail at the same time
- Replace error prints with info during state processing, as error is already logged above
- nuke 'No more free indices left' debug message
- cleanup of startup logs

Required-githooks: true

Signed-off-by: Alexander A Oganezov <alexander.a.oganezov@intel.com>
Copy link

github-actions bot commented Aug 12, 2024

Ticket title is 'cart: reduce flood of error prints when rpcs time out'
Status is 'Awaiting backport'
Labels: 'request_for_2.6.1'
https://daosio.atlassian.net/browse/DAOS-16330

@daosbuild1
Copy link
Collaborator

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on EL 9 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14915/1/execution/node/329/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on EL 8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14915/1/execution/node/354/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on Leap 15.5 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14915/1/execution/node/273/log

Required-githooks: true

Signed-off-by: Alexander A Oganezov <alexander.a.oganezov@intel.com>
@frostedcmos frostedcmos added the unclean-cherry-pick Indicates that a cherry-pick had merge conflicts that needed resolving. label Aug 12, 2024
@frostedcmos frostedcmos marked this pull request as ready for review August 12, 2024 18:42
@frostedcmos frostedcmos requested review from a team as code owners August 12, 2024 18:42
@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14915/2/execution/node/1442/log

@frostedcmos frostedcmos added the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label Aug 13, 2024
@frostedcmos frostedcmos requested a review from a team August 13, 2024 15:04
@frostedcmos frostedcmos requested a review from a team August 14, 2024 16:10
@mchaarawi mchaarawi merged commit ab25284 into release/2.6 Aug 15, 2024
50 of 52 checks passed
@mchaarawi mchaarawi deleted the aaoganez/DAOS-16330-2.6 branch August 15, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. unclean-cherry-pick Indicates that a cherry-pick had merge conflicts that needed resolving.
Development

Successfully merging this pull request may close these issues.

5 participants