Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-15997 build: bump mercury version to 2.4.0rc4 (#14873) #14883

Merged
merged 1 commit into from
Aug 7, 2024
Merged

DAOS-15997 build: bump mercury version to 2.4.0rc4 (#14873) #14883

merged 1 commit into from
Aug 7, 2024

Conversation

soumagne
Copy link
Collaborator

@soumagne soumagne commented Aug 6, 2024

Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@soumagne
DAOS-15997 build: bump mercury version to 2.4.0rc4 (#14873)
d51f2cf 
Required-githooks: true

Signed-off-by: Jerome Soumagne <jerome.soumagne@intel.com>
@soumagne soumagne requested a review from a team as a code owner August 6, 2024 21:35
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 6, 2024

Ticket title is 'Update mercury to 2.4.0'
Status is 'Awaiting backport'
Labels: 'request_for_2.6.1'
https://daosio.atlassian.net/browse/DAOS-15997

@soumagne soumagne added the unclean-cherry-pick Indicates that a cherry-pick had merge conflicts that needed resolving. label Aug 6, 2024
@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14883/1/execution/node/1535/log

@soumagne soumagne requested a review from frostedcmos August 7, 2024 16:40
@soumagne soumagne added the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label Aug 7, 2024
@soumagne
Copy link
Collaborator Author

soumagne commented Aug 7, 2024

one known failure in hardware medium stage https://daosio.atlassian.net/browse/DAOS-16007

@soumagne soumagne requested a review from a team August 7, 2024 18:39
@daltonbohning daltonbohning merged commit 3f0d0d1 into release/2.6 Aug 7, 2024
50 of 52 checks passed
@daltonbohning daltonbohning deleted the soumagne/mercury_240_26 branch August 7, 2024 18:55
Nasf-Fan pushed a commit that referenced this pull request Aug 8, 2024
@soumagne @Nasf-Fan
DAOS-15997 build: bump mercury version to 2.4.0rc4 (#14873) (#14883)
85c63df 
Signed-off-by: Jerome Soumagne <jerome.soumagne@intel.com>
@cdavis28 cdavis28 mentioned this pull request Aug 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianjmurrell brianjmurrell brianjmurrell approved these changes

@frostedcmos frostedcmos Awaiting requested review from frostedcmos

Assignees
No one assigned
Labels
forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. unclean-cherry-pick Indicates that a cherry-pick had merge conflicts that needed resolving.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@soumagne @daosbuild1 @brianjmurrell @daltonbohning