Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-16307 client: Defer creating network context in child processes #14875

Merged
merged 3 commits into from
Aug 16, 2024
Merged

DAOS-16307 client: Defer creating network context in child processes #14875

merged 3 commits into from
Aug 16, 2024

Conversation

wiliamhuang
Copy link
Contributor

Features: ioil pil4dfs

Create network context when a read/write operation is processed.

Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@wiliamhuang
DAOS-16307 client: Defer creating network context in child processes
1d9c1a4 
Features: ioil pil4dfs

Create network context when a read/write operation is encountered.

Required-githooks: true

Signed-off-by: Lei Huang <lei.huang@intel.com>
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 5, 2024 •
edited
Loading

Ticket title is 'Deferring creating network context after fork() until a read/write operation is issued'
Status is 'In Review'
Labels: 'intercept_lib'
https://daosio.atlassian.net/browse/DAOS-16307

@wiliamhuang wiliamhuang requested a review from mchaarawi August 5, 2024 22:04
@wiliamhuang wiliamhuang marked this pull request as ready for review August 6, 2024 16:30
@wiliamhuang wiliamhuang requested review from a team as code owners August 6, 2024 16:30
@wiliamhuang
Copy link
Contributor Author

All tests passed in CI.

mchaarawi
mchaarawi reviewed Aug 6, 2024
View reviewed changes
src/client/dfuse/il/int_posix.c Outdated
@@ -807,11 +807,6 @@ child_hdlr(void)
DL_WARN(rc, "daos_eq_lib_init() failed in child process");
daos_dti_reset();
ioil_eqh = ioil_iog.iog_main_eqh = DAOS_HDL_INVAL;
Copy link
Contributor

@mchaarawi mchaarawi Aug 6, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't think we should do this for0 IOIL.
IOIL only intercepts read/write calls unlike pil4dfs. So it's more likely that that context is going to be used in this case.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

child_hdlr() is executed once a child process is forked if the parent process calls open() to access files on daos. We do not know whether the child process only calls metadata related functions or not.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was not my point.
IOIL does not intercept any metadata or libaio calls, so creating a context here is not going to matter much and is only beneficial in case the child actually does IO that is intercepted.
But in pil4dfs case, the child will create additional network context now if it does libaio for example, and we already started creating aio context here taking away a resource from there.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok. Just reverted the change in libioil.

daltonbohning
daltonbohning previously approved these changes Aug 6, 2024
View reviewed changes
Copy link
Contributor

@daltonbohning daltonbohning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but will defer to Mohamad.

FYI Features: ioil doesn't cover all libioil tests because the il tag is used too.
So you'd need Features: ioil il
I'll create a ticket to update those

@wiliamhuang
empty commit to trigger rebuild
63d5e59 
Features: ioil il pil4dfs

Required-githooks: true

Signed-off-by: Lei Huang <lei.huang@intel.com>
@wiliamhuang
revert the change in libioil
0ca4e1f 
Features: pil4dfs

Required-githooks: true

Signed-off-by: Lei Huang <lei.huang@intel.com>
@daosbuild1
Copy link
Collaborator

Test stage Test RPMs on EL 8.6 completed with status FAILURE. https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-14875/2/display/redirect

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Large completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-14875/3/testReport/

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14875/3/execution/node/1556/log

@wiliamhuang wiliamhuang requested a review from a team August 8, 2024 14:47
@wiliamhuang wiliamhuang added the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label Aug 8, 2024
@wiliamhuang
Copy link
Contributor Author

Two failed tests in CI.

  1. intercept_multi_client.py:IorInterceptMultiClient.test_ior_intercept_libpil4dfs
    This is just due to noisy performance data.
  2. time out in pil4dfs_fio.py:Pil4dfsFio.test_pil4dfs_vs_dfs was reported in ticket https://daosio.atlassian.net/browse/DAOS-16315

@mchaarawi
Copy link
Contributor

Two failed tests in CI.

  1. intercept_multi_client.py:IorInterceptMultiClient.test_ior_intercept_libpil4dfs
    This is just due to noisy performance data.
  2. time out in pil4dfs_fio.py:Pil4dfsFio.test_pil4dfs_vs_dfs was reported in ticket https://daosio.atlassian.net/browse/DAOS-16315

TBH it's a bit risky to land changes that actually do effect existing tests that are intermittently failing. let's hold this and investigate the other issues first before landing this one.

@wiliamhuang
Copy link
Contributor Author

Two failed tests in CI.

  1. intercept_multi_client.py:IorInterceptMultiClient.test_ior_intercept_libpil4dfs
    This is just due to noisy performance data.
  2. time out in pil4dfs_fio.py:Pil4dfsFio.test_pil4dfs_vs_dfs was reported in ticket https://daosio.atlassian.net/browse/DAOS-16315

TBH it's a bit risky to land changes that actually do effect existing tests that are intermittently failing. let's hold this and investigate the other issues first before landing this one.

ok. I am working on https://daosio.atlassian.net/browse/DAOS-16315. Thank you!

@wiliamhuang wiliamhuang removed the request for review from a team August 8, 2024 14:59
@wiliamhuang
Copy link
Contributor Author

Two failed tests in CI.

  1. intercept_multi_client.py:IorInterceptMultiClient.test_ior_intercept_libpil4dfs
    This is just due to noisy performance data.
  2. time out in pil4dfs_fio.py:Pil4dfsFio.test_pil4dfs_vs_dfs was reported in ticket https://daosio.atlassian.net/browse/DAOS-16315

TBH it's a bit risky to land changes that actually do effect existing tests that are intermittently failing. let's hold this and investigate the other issues first before landing this one.

Can we land this PR now? The failure of libaio + fork() in fio is caused by mercury 2.4.0rc4.

@wiliamhuang wiliamhuang requested a review from a team August 14, 2024 21:30
@mchaarawi mchaarawi merged commit 1b85bb0 into master Aug 16, 2024
52 of 55 checks passed
@mchaarawi mchaarawi deleted the lei/DAOS-16307 branch August 16, 2024 13:22
wiliamhuang added a commit that referenced this pull request Aug 19, 2024
@wiliamhuang
DAOS-16307 client: Defer creating network context in child processes (#…
a7646d9 
…14875)

Create network context when a read/write operation is encountered.

Signed-off-by: Lei Huang <lei.huang@intel.com>
@wiliamhuang wiliamhuang mentioned this pull request Aug 19, 2024
Merged
18 tasks
@mjmac mjmac mentioned this pull request Nov 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daltonbohning daltonbohning daltonbohning approved these changes

@mchaarawi mchaarawi mchaarawi approved these changes

Assignees
No one assigned
Labels
forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wiliamhuang @daosbuild1 @mchaarawi @daltonbohning