Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-14544 rsvc: crt tree type usgae fix #14834

Merged
merged 1 commit into from
Aug 25, 2024
Merged

DAOS-14544 rsvc: crt tree type usgae fix #14834

merged 1 commit into from
Aug 25, 2024

Conversation

liw
Copy link
Contributor

@liw liw commented Jul 29, 2024 •
edited
Loading

From @yyyshi: It is likely that a simplified implementation was used in the early stages of the project and updates were ignored in the future, i think a fix is needed.

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@github-actions GitHub Actions
Copy link

Ticket title is 'crt tree type usage fix'
Status is 'Open'
https://daosio.atlassian.net/browse/DAOS-14544

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium Verbs Provider completed with status FAILURE. https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-14834/1/display/redirect

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14834/1/execution/node/1416/log

@yyyshi @liw
DAOS-14544 rsvc: crt tree type usgae fix
e184cbd 
It is likely that a simplified implementation was used in the early
stages of the project and updates were ignored in the future, i think a
fix is needed.

Signed-off-by: shiying <yshi1210@gmail.com>
Signed-off-by: Li Wei <wei.g.li@intel.com>
Required-githooks: true
@liw liw force-pushed the liw/yyyshi/fix-tree-type branch from fea0dff to e184cbd Compare July 30, 2024 04:48
@liw liw marked this pull request as ready for review August 23, 2024 04:42
@liw liw requested review from a team as code owners August 23, 2024 04:42
@liw liw requested review from frostedcmos and kccain August 23, 2024 04:42
@liw liw requested a review from a team August 25, 2024 01:26
@frostedcmos frostedcmos merged commit fd9e945 into master Aug 25, 2024
52 of 53 checks passed
@frostedcmos frostedcmos deleted the liw/yyyshi/fix-tree-type branch August 25, 2024 19:17
liw added a commit that referenced this pull request Aug 26, 2024
@liw @yyyshi
DAOS-14544 rsvc: crt tree type usage fix (#14834)
4308ae7 
- Change from flat to knomial tree for broadcasts


Signed-off-by: shiying <yshi1210@gmail.com>
Signed-off-by: Li Wei <wei.g.li@intel.com>
Co-authored-by: shiying <yshi1210@gmail.com>
Required-githooks: true
NiuYawei pushed a commit that referenced this pull request Sep 2, 2024
@liw @yyyshi
DAOS-14544 rsvc: crt tree type usage fix (#14834) (#15005)
a4352e1 
- Change from flat to knomial tree for broadcasts

Signed-off-by: shiying <yshi1210@gmail.com>
Signed-off-by: Li Wei <wei.g.li@intel.com>
Co-authored-by: shiying <yshi1210@gmail.com>
@jolivier23 jolivier23 mentioned this pull request Sep 4, 2024
Merged
@mjmac mjmac mentioned this pull request Nov 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kccain kccain kccain approved these changes

@frostedcmos frostedcmos frostedcmos approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@liw @daosbuild1 @frostedcmos @kccain @yyyshi