Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-16238 utils: Add valgrind suppressions for Go runtime #14823

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

kjacque
Copy link
Contributor

@kjacque kjacque commented Jul 25, 2024

Added some more Go runtime suppressions. I've added counterparts for all functions already on the list, as well as the false positives that have been recently spotted.

Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

Added some more Go runtime suppressions. I've added counterparts for
all functions already on the list, as well as the false positives that
have been recently spotted.

Required-githooks: true

Signed-off-by: Kris Jacque <kris.jacque@intel.com>
@kjacque kjacque requested review from mjmac, tanabarr and knard38 July 25, 2024 19:40
@kjacque kjacque self-assigned this Jul 25, 2024
@kjacque kjacque requested review from a team as code owners July 25, 2024 19:40
Copy link

github-actions bot commented Jul 25, 2024

Ticket title is 'Sporadic invalid read/write NLT issues in master PRs'
Status is 'In Review'
https://daosio.atlassian.net/browse/DAOS-16238

@kjacque
Copy link
Contributor Author

kjacque commented Jul 25, 2024

No Features tag needed, as this affects only NLT.

Copy link
Contributor

@mjmac mjmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🫡 LGTM

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium Verbs Provider completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-14823/1/testReport/

@kjacque
Copy link
Contributor Author

kjacque commented Jul 29, 2024

NLT has passed. This patch only affects the valgrind suppressions. It could not have affected the hardware tests.

@kjacque kjacque added the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label Jul 29, 2024
@kjacque kjacque requested a review from a team July 29, 2024 15:26
@daltonbohning daltonbohning merged commit f500301 into master Jul 29, 2024
55 of 57 checks passed
@daltonbohning daltonbohning deleted the kjacque/more-memcheck-supp branch July 29, 2024 17:46
kjacque added a commit that referenced this pull request Aug 1, 2024
Added some more Go runtime suppressions. I've added counterparts for
all functions already on the list, as well as the false positives that
have been recently spotted.

Required-githooks: true

Signed-off-by: Kris Jacque <kris.jacque@intel.com>
daltonbohning pushed a commit that referenced this pull request Aug 5, 2024
…14863)

Added some more Go runtime suppressions. I've added counterparts for
all functions already on the list, as well as the false positives that
have been recently spotted.

Signed-off-by: Kris Jacque <kris.jacque@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed.
Development

Successfully merging this pull request may close these issues.

7 participants