Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-16265 test: Add debug for common test dir between variants #14818

Merged
merged 6 commits into from
Aug 22, 2024

Conversation

phender
Copy link
Contributor

@phender phender commented Jul 25, 2024

Help determine contents of common test dir between test variants.

Skip-unit-tests: true
Skip-fault-injection-test: true
Allow-unstable-test: true
Test-tag: EcodFioRebuild

Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

Help determine contents of common test dir between test variants.

Skip-unit-tests: true
Skip-fault-injection-test: true
Allow-unstable-test: true
Test-tag: EcodFioRebuild

Required-githooks: true

Signed-off-by: Phil Henderson <phillip.henderson@intel.com>
@phender phender requested review from a team as code owners July 25, 2024 12:43
Copy link

Ticket title is '[12-24]-./erasurecode/rebuild_fio.py:EcodFioRebuild.test_ec_online_rebuild_fio tests fail due to daos_server startup problem.'
Status is 'Open'
Labels: 'ci_master_weekly,md_on_ssd,weekly_test'
https://daosio.atlassian.net/browse/DAOS-16265

Skip-unit-tests: true
Skip-fault-injection-test: true
Allow-unstable-test: true
Test-tag: EcodFioRebuild Snapshot

Required-githooks: true

Signed-off-by: Phil Henderson <phillip.henderson@intel.com>
Skip-unit-tests: true
Skip-fault-injection-test: true
Allow-unstable-test: true
Test-tag: EcodFioRebuild Snapshot

Required-githooks: true

Signed-off-by: Phil Henderson <phillip.henderson@intel.com>
Copy link
Contributor

@daltonbohning daltonbohning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test.py has conflicts

mjean308
mjean308 previously approved these changes Aug 13, 2024
Skip-unit-tests: true
Skip-fault-injection-test: true
Allow-unstable-test: true
Test-tag: EcodFioRebuild Snapshot

Required-githooks: true

Signed-off-by: Phil Henderson <phillip.henderson@intel.com>
mjean308
mjean308 previously approved these changes Aug 13, 2024
daltonbohning
daltonbohning previously approved these changes Aug 13, 2024
@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Large completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14818/4/execution/node/1008/log

Skip-unit-tests: true
Skip-fault-injection-test: true
Allow-unstable-test: true
Test-tag: EcodFioRebuild Snapshot

Required-githooks: true

Signed-off-by: Phil Henderson <phillip.henderson@intel.com>
@phender phender dismissed stale reviews from daltonbohning and mjean308 via 208bf03 August 17, 2024 01:35
@phender
Copy link
Contributor Author

phender commented Aug 19, 2024

Tests passed in

Updated output:

  • Initially and until the directory is +90% full it will only display the df output:
2024-08-17 06:30:10,553 test             L0768 INFO | ----------------------------------------------------------------------------------------------------
2024-08-17 06:30:10,553 test             L0769 DEBUG| Common test directory (/var/tmp/daos_testing) contents:
2024-08-17 06:30:10,554 run_utils        L0462 DEBUG| Running on wolf-[51,110-116] with a 120 second timeout: df -h /var/tmp/daos_testing
2024-08-17 06:30:10,780 run_utils        L0336 DEBUG|   wolf-51 (rc=0):
2024-08-17 06:30:10,780 run_utils        L0341 DEBUG|     Filesystem      Size  Used Avail Use% Mounted on
2024-08-17 06:30:10,780 run_utils        L0341 DEBUG|     /dev/sda7        28G   26M   26G   1% /var/tmp
2024-08-17 06:30:10,780 run_utils        L0336 DEBUG|   wolf-110 (rc=0):
2024-08-17 06:30:10,780 run_utils        L0341 DEBUG|     Filesystem      Size  Used Avail Use% Mounted on
2024-08-17 06:30:10,780 run_utils        L0341 DEBUG|     /dev/sda7        28G  1.1G   25G   5% /var/tmp
2024-08-17 06:30:10,780 run_utils        L0336 DEBUG|   wolf-113 (rc=0):
2024-08-17 06:30:10,780 run_utils        L0341 DEBUG|     Filesystem      Size  Used Avail Use% Mounted on
2024-08-17 06:30:10,780 run_utils        L0341 DEBUG|     /dev/sda7        28G  527M   26G   2% /var/tmp
2024-08-17 06:30:10,781 run_utils        L0336 DEBUG|   wolf-114 (rc=0):
2024-08-17 06:30:10,781 run_utils        L0341 DEBUG|     Filesystem      Size  Used Avail Use% Mounted on
2024-08-17 06:30:10,781 run_utils        L0341 DEBUG|     /dev/sda7        28G  341M   26G   2% /var/tmp
2024-08-17 06:30:10,781 run_utils        L0336 DEBUG|   wolf-116 (rc=0):
2024-08-17 06:30:10,781 run_utils        L0341 DEBUG|     Filesystem      Size  Used Avail Use% Mounted on
2024-08-17 06:30:10,781 run_utils        L0341 DEBUG|     /dev/sda7        28G  1.1M   26G   1% /var/tmp
2024-08-17 06:30:10,781 run_utils        L0336 DEBUG|   wolf-111 (rc=0):
2024-08-17 06:30:10,781 run_utils        L0341 DEBUG|     Filesystem      Size  Used Avail Use% Mounted on
2024-08-17 06:30:10,781 run_utils        L0341 DEBUG|     /dev/sda7        28G  378M   26G   2% /var/tmp
2024-08-17 06:30:10,781 run_utils        L0336 DEBUG|   wolf-115 (rc=0):
2024-08-17 06:30:10,781 run_utils        L0341 DEBUG|     Filesystem      Size  Used Avail Use% Mounted on
2024-08-17 06:30:10,781 run_utils        L0341 DEBUG|     /dev/sda7        28G  236M   26G   1% /var/tmp
2024-08-17 06:30:10,781 run_utils        L0336 DEBUG|   wolf-112 (rc=0):
2024-08-17 06:30:10,781 run_utils        L0341 DEBUG|     Filesystem      Size  Used Avail Use% Mounted on
2024-08-17 06:30:10,781 run_utils        L0341 DEBUG|     /dev/sda7        28G  312M   26G   2% /var/tmp
2024-08-17 06:30:10,782 test             L0775 INFO | ----------------------------------------------------------------------------------------------------

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Large completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14818/6/execution/node/922/log

@daltonbohning daltonbohning requested a review from a team August 22, 2024 16:06
@daltonbohning daltonbohning added the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label Aug 22, 2024
@daltonbohning daltonbohning merged commit dd488d1 into master Aug 22, 2024
45 of 47 checks passed
@daltonbohning daltonbohning deleted the pahender/DAOS-16265 branch August 22, 2024 16:09
phender added a commit that referenced this pull request Aug 29, 2024
Help determine contents of common test dir between test variants.

Signed-off-by: Phil Henderson <phillip.henderson@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed.
Development

Successfully merging this pull request may close these issues.

4 participants