Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-16159 control: Accept UCX full transport names #14768

Merged
merged 1 commit into from
Jul 16, 2024
Merged

DAOS-16159 control: Accept UCX full transport names #14768

merged 1 commit into from
Jul 16, 2024

Conversation

kjacque
Copy link
Contributor

@kjacque kjacque commented Jul 12, 2024 •
edited
Loading

  • Include the original UCX transport name (e.g. "ucx+rc_verbs") in the list of accepted UCX providers, alongside the aliases (e.g. "ucx+rc_v", "ucx+rc").

Features: control

Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@kjacque
DAOS-16159 control: Accept UCX full transport names
c1a49b1 
- Include the original UCX transport name (e.g. "ucx+rc_verbs") in
  the list of accepted UCX providers, alongside the aliases (e.g.
  "ucx+rc_v", "ucx+rc").

Features: control

Required-githooks: true

Signed-off-by: Kris Jacque <kris.jacque@intel.com>
@kjacque kjacque self-assigned this Jul 12, 2024
@kjacque kjacque requested review from a team as code owners July 12, 2024 23:48
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 12, 2024 •
edited
Loading

Ticket title is 'control plane needs to support provider:ucx+dc_mlx5'
Status is 'In Review'
Labels: 'lrz,scrubbed_2.8'
https://daosio.atlassian.net/browse/DAOS-16159

@kjacque kjacque requested review from mjmac, tanabarr and knard38 July 12, 2024 23:48
knard38
knard38 approved these changes Jul 15, 2024
View reviewed changes
Copy link
Contributor

@knard38 knard38 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Large completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14768/1/execution/node/1508/log

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-14768/1/testReport/

@kjacque
Copy link
Contributor Author

kjacque commented Jul 16, 2024

Failures are known issues:

I would like this PR to be force landed.

@kjacque kjacque added the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label Jul 16, 2024
@kjacque kjacque requested a review from a team July 16, 2024 01:07
@daltonbohning daltonbohning merged commit 8496c20 into master Jul 16, 2024
54 of 57 checks passed
@daltonbohning daltonbohning deleted the kjacque/ucx-prov-names branch July 16, 2024 14:52
grom72 pushed a commit to grom72/daos that referenced this pull request Jul 25, 2024
@kjacque @grom72
DAOS-16159 control: Accept UCX full transport names (daos-stack#14768)
8936367 
- Include the original UCX transport name (e.g. "ucx+rc_verbs") in
  the list of accepted UCX providers, alongside the aliases (e.g.
  "ucx+rc_v", "ucx+rc").

Signed-off-by: Kris Jacque <kris.jacque@intel.com>
kjacque added a commit that referenced this pull request Jul 30, 2024
@kjacque
DAOS-16159 control: Accept UCX full transport names (#14768)
152047b 
- Include the original UCX transport name (e.g. "ucx+rc_verbs") in
  the list of accepted UCX providers, alongside the aliases (e.g.
  "ucx+rc_v", "ucx+rc").

Signed-off-by: Kris Jacque <kris.jacque@intel.com>
daltonbohning pushed a commit that referenced this pull request Jul 31, 2024
@kjacque
DAOS-16159 control: Accept UCX full transport names (#14768) (#14842)
69469aa 
- Include the original UCX transport name (e.g. "ucx+rc_verbs") in
  the list of accepted UCX providers, alongside the aliases (e.g.
  "ucx+rc_v", "ucx+rc").

Signed-off-by: Kris Jacque <kris.jacque@intel.com>
@mjmac mjmac mentioned this pull request Aug 7, 2024
Merged
@mjmac mjmac mentioned this pull request Nov 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knard38 knard38 knard38 approved these changes

@tanabarr tanabarr tanabarr approved these changes

@mjmac mjmac Awaiting requested review from mjmac

Assignees

@kjacque kjacque

Labels
forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kjacque @daosbuild1 @tanabarr @knard38 @daltonbohning