Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-16228 test: update suppressions for NLT again #14762

Merged
merged 1 commit into from
Jul 15, 2024
Merged

DAOS-16228 test: update suppressions for NLT again #14762

merged 1 commit into from
Jul 15, 2024

Conversation

kccain
Copy link
Contributor

@kccain kccain commented Jul 12, 2024

Skip-test: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@kccain
DAOS-623 test: update suppressions for NLT again
4cee175 
Skip-test: true

Signed-off-by: Kenneth Cain <kenneth.c.cain@intel.com>
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 12, 2024 •
edited
Loading

Ticket title is 'valgrind suppression needed for Go function __tsan_go_atomic32_store seen in NLT testing'
Status is 'In Progress'
https://daosio.atlassian.net/browse/DAOS-16228

@kccain kccain requested review from daltonbohning and phender July 12, 2024 21:15
@kccain kccain mentioned this pull request Jul 12, 2024
Merged
18 tasks
daltonbohning
daltonbohning approved these changes Jul 12, 2024
View reviewed changes
Copy link
Contributor

@daltonbohning daltonbohning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but as @phender pointed out we should create a ticket for merge approvals in backport is needed

@kccain
Copy link
Contributor Author

kccain commented Jul 15, 2024

Filed new ticket https://daosio.atlassian.net/browse/DAOS-16228 for this issue. Updating the title in github UI to reflect this

@kccain kccain changed the title DAOS-623 test: update suppressions for NLT again DAOS-16228 test: update suppressions for NLT again Jul 15, 2024
@kccain kccain added the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label Jul 15, 2024
@kccain kccain marked this pull request as ready for review July 15, 2024 14:26
@kccain kccain requested review from a team as code owners July 15, 2024 14:26
@kccain kccain requested a review from a team July 15, 2024 14:57
@daltonbohning daltonbohning merged commit 27f5e90 into master Jul 15, 2024
46 of 47 checks passed
@daltonbohning daltonbohning deleted the kccain/daos_623_suppression branch July 15, 2024 15:13
grom72 pushed a commit to grom72/daos that referenced this pull request Jul 25, 2024
@kccain @grom72
DAOS-16228 test: update suppressions for NLT again (daos-stack#14762)
2476e69 
Signed-off-by: Kenneth Cain <kenneth.c.cain@intel.com>
kccain added a commit that referenced this pull request Jul 31, 2024
@kccain
DAOS-16228 test: update suppressions for NLT again (#14762)
c15f458 
Skip-test: true

Signed-off-by: Kenneth Cain <kenneth.c.cain@intel.com>
mchaarawi pushed a commit that referenced this pull request Jul 31, 2024
@kccain
DAOS-16228 test: update suppressions for NLT again (#14762) (#14851)
e204d6a 
Signed-off-by: Kenneth Cain <kenneth.c.cain@intel.com>
@mjmac mjmac mentioned this pull request Aug 7, 2024
Merged
@mjmac mjmac mentioned this pull request Nov 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjacque kjacque kjacque approved these changes

@daltonbohning daltonbohning daltonbohning approved these changes

@phender phender Awaiting requested review from phender

Assignees
No one assigned
Labels
forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kccain @daltonbohning @kjacque