Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-16215 test: add pciutils-devel requirement for client-tests #14746

Merged
merged 2 commits into from
Jul 15, 2024

Conversation

daltonbohning
Copy link
Contributor

Add pciutils-devel requirement for client-tests package. Specifically needed for the dfuse/daos_build.py test

Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

Add pciutils-devel requirement for client-tests package.
Specifically needed for the dfuse/daos_build.py test

Required-githooks: true

Signed-off-by: Dalton Bohning <dalton.bohning@intel.com>
@daltonbohning daltonbohning self-assigned this Jul 11, 2024
Copy link

Ticket title is 'dfuse/daos_build.py:DaosBuild.test_dfuse_daos_build_wb - fatal error: pci/pci.h: No such file or directory'
Status is 'In Progress'
Labels: 'ci_master_daily,daily_test,pr_test'
https://daosio.atlassian.net/browse/DAOS-16215

tanabarr
tanabarr previously approved these changes Jul 11, 2024
Copy link
Contributor

@tanabarr tanabarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for fixing this @daltonbohning , don't forget to update the debian/ files with the packaging change

@daltonbohning
Copy link
Contributor Author

thanks for fixing this @daltonbohning , don't forget to update the debian/ files with the packaging change

Gah! Thanks. I did forget :(

Required-githooks: true

Signed-off-by: Dalton Bohning <dalton.bohning@intel.com>
@daltonbohning daltonbohning marked this pull request as ready for review July 15, 2024 15:35
@daltonbohning daltonbohning requested a review from a team as a code owner July 15, 2024 15:35
Copy link
Contributor

@brianjmurrell brianjmurrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed elsewhere, there is I think a better way to do all of this than duplicating BuildRequires: into daos-client-tests' Requires:. But since this is the path we are on currently, this change works.

@daltonbohning daltonbohning requested a review from a team July 15, 2024 17:07
@daltonbohning daltonbohning merged commit 8952b5b into master Jul 15, 2024
52 checks passed
@daltonbohning daltonbohning deleted the dbohning/daos-16215 branch July 15, 2024 17:08
grom72 pushed a commit to grom72/daos that referenced this pull request Jul 25, 2024
…s-stack#14746)

Add pciutils-devel requirement for client-tests package.
Specifically needed for the dfuse/daos_build.py test

Signed-off-by: Dalton Bohning <dalton.bohning@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants