-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DAOS-16215 test: add pciutils-devel requirement for client-tests #14746
Conversation
Add pciutils-devel requirement for client-tests package. Specifically needed for the dfuse/daos_build.py test Required-githooks: true Signed-off-by: Dalton Bohning <dalton.bohning@intel.com>
Ticket title is 'dfuse/daos_build.py:DaosBuild.test_dfuse_daos_build_wb - fatal error: pci/pci.h: No such file or directory' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for fixing this @daltonbohning , don't forget to update the debian/ files with the packaging change
Gah! Thanks. I did forget :( |
Required-githooks: true Signed-off-by: Dalton Bohning <dalton.bohning@intel.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed elsewhere, there is I think a better way to do all of this than duplicating BuildRequires:
into daos-client-tests
' Requires:
. But since this is the path we are on currently, this change works.
…s-stack#14746) Add pciutils-devel requirement for client-tests package. Specifically needed for the dfuse/daos_build.py test Signed-off-by: Dalton Bohning <dalton.bohning@intel.com>
Add pciutils-devel requirement for client-tests package. Specifically needed for the dfuse/daos_build.py test
Required-githooks: true
Before requesting gatekeeper:
Features:
(orTest-tag*
) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.Gatekeeper: