Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-16005 object: check resent coll_punch on leader and relay engine #14659

Merged
merged 1 commit into from
Jul 22, 2024
Merged

DAOS-16005 object: check resent coll_punch on leader and relay engine #14659

merged 1 commit into from
Jul 22, 2024

Conversation

Nasf-Fan
Copy link
Contributor

For collective punch RPC handler on leader or relay engine, if related DTX has already been prepared when handling resent RPC, then we should avoid re-executing the punch locally. Otherwise, it may cleanup former prepared DTX entry by wrong.

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@github-actions GitHub Actions
Copy link

Ticket title is 'aurora soak stress: Pool connect issues/pool query appear to be hanging'
Status is 'In Progress'
Labels: 'daos_ecb_issue,daos_ecb_scale,scrubbed_2.8,soak,triaged'
https://daosio.atlassian.net/browse/DAOS-16005

@Nasf-Fan Nasf-Fan force-pushed the Nasf-Fan/DAOS-16005_2 branch from 8998c7b to e6e69c2 Compare June 28, 2024 03:06
@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14659/2/execution/node/1551/log

@Nasf-Fan Nasf-Fan force-pushed the Nasf-Fan/DAOS-16005_2 branch 2 times, most recently from c899d12 to 8c4db79 Compare July 11, 2024 06:09
@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14659/5/execution/node/1505/log

@Nasf-Fan Nasf-Fan force-pushed the Nasf-Fan/DAOS-16005_2 branch from 8c4db79 to a5959eb Compare July 14, 2024 08:15
@Nasf-Fan
DAOS-16005 object: check resent coll_punch on leader and relay engine
74de330 
For collective punch RPC handler on leader or relay engine, if related
DTX has already been prepared when handling resent RPC, then we should
avoid re-executing the punch locally. Otherwise, it may cleanup former
prepared DTX entry by wrong.

Signed-off-by: Fan Yong <fan.yong@intel.com>
@Nasf-Fan Nasf-Fan force-pushed the Nasf-Fan/DAOS-16005_2 branch from a5959eb to 74de330 Compare July 15, 2024 16:01
@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-14659/10/testReport/

@Nasf-Fan
Copy link
Contributor Author

test_dfuse_daos_build_wb failed for DAOS-16215, not related with the patch

@Nasf-Fan Nasf-Fan marked this pull request as ready for review July 17, 2024 06:53
@Nasf-Fan Nasf-Fan requested review from a team as code owners July 17, 2024 06:53
@Nasf-Fan Nasf-Fan requested review from liuxuezhao and NiuYawei July 17, 2024 06:53
NiuYawei
NiuYawei approved these changes Jul 19, 2024
View reviewed changes
src/vos/vos_dtx.c
if (age >= DAOS_AGG_THRESHOLD)
D_WARN("DTX "DF_DTI" (state:%u, age:%u) still references the data, "
"cannot be (VOS) aggregated\n",
DP_DTI(&DAE_XID(dae)), vos_dtx_status(dae), age);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's better to rate limit this warning message, otherwise, the log file will be flooded with such message when some data failed to be DTX committed for a long time.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The warning message may be triggered for different DTX entries. Limiting the rate may miss some DTX information? Not sure whether we have some efficient way to skip repeated log message or not.

@Nasf-Fan Nasf-Fan requested a review from a team July 22, 2024 01:53
@mchaarawi mchaarawi merged commit 6553928 into master Jul 22, 2024
49 of 53 checks passed
@mchaarawi mchaarawi deleted the Nasf-Fan/DAOS-16005_2 branch July 22, 2024 13:25
@Nasf-Fan Nasf-Fan mentioned this pull request Jul 23, 2024
Closed
18 tasks
grom72 pushed a commit to grom72/daos that referenced this pull request Jul 25, 2024
@Nasf-Fan @grom72
DAOS-16005 object: check resent coll_punch on leader and relay engine (…
5809efa 
…daos-stack#14659)

For collective punch RPC handler on leader or relay engine, if related
DTX has already been prepared when handling resent RPC, then we should
avoid re-executing the punch locally. Otherwise, it may cleanup former
prepared DTX entry by wrong.

Signed-off-by: Fan Yong <fan.yong@intel.com>
Nasf-Fan added a commit that referenced this pull request Jul 26, 2024
@Nasf-Fan
DAOS-16005 object: check resent coll_punch on leader and relay engine (…
72d410b 
…#14659)

For collective punch RPC handler on leader or relay engine, if related
DTX has already been prepared when handling resent RPC, then we should
avoid re-executing the punch locally. Otherwise, it may cleanup former
prepared DTX entry by wrong.

Signed-off-by: Fan Yong <fan.yong@intel.com>
@Nasf-Fan Nasf-Fan mentioned this pull request Jul 26, 2024
Merged
18 tasks
daltonbohning pushed a commit that referenced this pull request Jul 26, 2024
@Nasf-Fan @daltonbohning
DAOS-16005 object: check resent coll_punch on leader and relay engine (…
5861e0d 
…#14659)

For collective punch RPC handler on leader or relay engine, if related
DTX has already been prepared when handling resent RPC, then we should
avoid re-executing the punch locally. Otherwise, it may cleanup former
prepared DTX entry by wrong.

Signed-off-by: Fan Yong <fan.yong@intel.com>
Nasf-Fan added a commit that referenced this pull request Jul 28, 2024
@Nasf-Fan
DAOS-16005 object: check resent coll_punch on leader and relay engine (…
cdf5494 
…#14659)

For collective punch RPC handler on leader or relay engine, if related
DTX has already been prepared when handling resent RPC, then we should
avoid re-executing the punch locally. Otherwise, it may cleanup former
prepared DTX entry by wrong.

Allow-unstable-test: true

Signed-off-by: Fan Yong <fan.yong@intel.com>
daltonbohning pushed a commit that referenced this pull request Jul 29, 2024
@Nasf-Fan @daltonbohning
DAOS-16005 object: check resent coll_punch on leader and relay engine (…
dc06851 
…#14659)

For collective punch RPC handler on leader or relay engine, if related
DTX has already been prepared when handling resent RPC, then we should
avoid re-executing the punch locally. Otherwise, it may cleanup former
prepared DTX entry by wrong.

Signed-off-by: Fan Yong <fan.yong@intel.com>
daltonbohning pushed a commit that referenced this pull request Jul 31, 2024
@Nasf-Fan @daltonbohning
DAOS-16005 object: check resent coll_punch on leader and relay engine (…
3a70469 
…#14659)

For collective punch RPC handler on leader or relay engine, if related
DTX has already been prepared when handling resent RPC, then we should
avoid re-executing the punch locally. Otherwise, it may cleanup former
prepared DTX entry by wrong.

Allow-unstable-test: true

Signed-off-by: Fan Yong <fan.yong@intel.com>
daltonbohning pushed a commit that referenced this pull request Aug 12, 2024
@Nasf-Fan
DAOS-16005 object: check resent coll_punch on leader and relay engine (…
9325b67 
…#14659) (#14826)

For collective punch RPC handler on leader or relay engine, if related
DTX has already been prepared when handling resent RPC, then we should
avoid re-executing the punch locally. Otherwise, it may cleanup former
prepared DTX entry by wrong.

Signed-off-by: Fan Yong <fan.yong@intel.com>
@cdavis28 cdavis28 mentioned this pull request Aug 12, 2024
Merged
@mjmac mjmac mentioned this pull request Nov 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NiuYawei NiuYawei NiuYawei approved these changes

@liuxuezhao liuxuezhao liuxuezhao approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Nasf-Fan @daosbuild1 @liuxuezhao @NiuYawei @mchaarawi