Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-16101 mgmt: enhanced interoperability for MGMT module #14638

Merged
merged 6 commits into from
Jul 2, 2024
Merged

DAOS-16101 mgmt: enhanced interoperability for MGMT module #14638

merged 6 commits into from
Jul 2, 2024

Conversation

wangshilong
Copy link
Contributor

DAOS release 2.6 bumped mgmt RPC version because of CR feature, This PR focuses on ensuring backward compatibility and interoperability between DAOS version 2.4 and 2.6 for MGMT module.

Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@wangshilong
DAOS-16101 mgmt: enhanced interoperability for MGMT module
a0c43b5 
DAOS release 2.6 bumped mgmt RPC version because of CR feature,
This PR focuses on ensuring backward compatibility and interoperability
between DAOS version 2.4 and 2.6 for MGMT module.

Required-githooks: true
Signed-off-by: Wang Shilong <shilong.wang@intel.com>
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 25, 2024 •
edited
Loading

Ticket title is 'client at 2.6-rc1 fails to connect to 2.4.2 server/pool'
Status is 'In Review'
Labels: 'esc_missing_test,interop,lrz,scrubbed_2.8'
https://daosio.atlassian.net/browse/DAOS-16101

@daosbuild1
Copy link
Collaborator

Test stage Build on Leap 15.5 with Intel-C and TARGET_PREFIX completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14638/1/execution/node/387/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on EL 9 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14638/1/execution/node/339/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on EL 8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14638/1/execution/node/317/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on Leap 15.5 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14638/1/execution/node/336/log

@daosbuild1
Copy link
Collaborator

Test stage Build DEB on Ubuntu 20.04 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14638/1/execution/node/313/log

Michael-Hennecke
Michael-Hennecke reviewed Jun 25, 2024
View reviewed changes
src/mgmt/cli_mgmt.c Outdated
rc = daos_rpc_register(&mgmt_proto_fmt_v3, MGMT_PROTO_CLI_COUNT,
NULL, DAOS_MGMT_MODULE);
} else {
D_ERROR("%d version mgmt RPC not supported.\n", dc_mgmt_proto_version);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"version %d" instead of "%d version"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

mchaarawi
mchaarawi previously approved these changes Jun 25, 2024
View reviewed changes
@wangshilong
address comment
6126a0b 
Required-githooks: true

Signed-off-by: Wang Shilong <shilong.wang@intel.com>
@wangshilong
Merge branch 'master' of github.com:daos-stack/daos into shilongw/DAO…
65adbd1 
…S-16101
@daosbuild1
Copy link
Collaborator

Test stage Build on Leap 15.5 with Intel-C and TARGET_PREFIX completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14638/2/execution/node/571/log

@wangshilong
fix build failure
689a168 
Required-githooks: true

Signed-off-by: Wang Shilong <shilong.wang@intel.com>
@daosbuild1
Copy link
Collaborator

Test stage NLT on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-14638/3/testReport/

@daosbuild1
Copy link
Collaborator

Test stage Functional on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14638/3/execution/node/1189/log

@daosbuild1
Copy link
Collaborator

Test stage NLT on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-14638/4/testReport/

@wangshilong
just test
fb33b81 
Required-githooks: true

Signed-off-by: Wang Shilong <shilong.wang@intel.com>
@wangshilong wangshilong added the priority Ticket has high priority (automatically managed) label Jun 27, 2024
@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14638/9/execution/node/1505/log

@wangshilong
Copy link
Contributor Author

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14638/9/execution/node/1505/log

Test failure is related to DAOS-16007 which is a rebuild/reintegration bug, @daos-stack/daos-gatekeeper please consider force landing PR instead of retriggering hardware test.

@wangshilong wangshilong requested a review from a team July 2, 2024 01:06
@wangshilong wangshilong added the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label Jul 2, 2024
@gnailzenh gnailzenh merged commit 4492030 into master Jul 2, 2024
49 of 52 checks passed
@gnailzenh gnailzenh deleted the shilongw/DAOS-16101 branch July 2, 2024 01:50
wangshilong added a commit that referenced this pull request Jul 2, 2024
@wangshilong
DAOS-16101 mgmt: enhanced interoperability for MGMT module (#14638)
afaa52f 
* DAOS-16101 mgmt: enhanced interoperability for MGMT module

DAOS release 2.6 bumped mgmt RPC version because of CR feature,
This PR focuses on ensuring backward compatibility and interoperability
between DAOS version 2.4 and 2.6 for MGMT module.

Signed-off-by: Wang Shilong <shilong.wang@intel.com>
jolivier23 pushed a commit that referenced this pull request Jul 2, 2024
@wangshilong @jolivier23
DAOS-16101 mgmt: enhanced interoperability for MGMT module (#14638)
b1e8c36 
* DAOS-16101 mgmt: enhanced interoperability for MGMT module

DAOS release 2.6 bumped mgmt RPC version because of CR feature,
This PR focuses on ensuring backward compatibility and interoperability
between DAOS version 2.4 and 2.6 for MGMT module.

Signed-off-by: Wang Shilong <shilong.wang@intel.com>
gnailzenh pushed a commit that referenced this pull request Jul 3, 2024
@wangshilong
DAOS-16101 mgmt: enhanced interoperability for MGMT module (#14638) (#…
a1d3678 
…14678)

* DAOS-16101 mgmt: enhanced interoperability for MGMT module

DAOS release 2.6 bumped mgmt RPC version because of CR feature,
This PR focuses on ensuring backward compatibility and interoperability
between DAOS version 2.4 and 2.6 for MGMT module.

Signed-off-by: Wang Shilong <shilong.wang@intel.com>
grom72 pushed a commit to grom72/daos that referenced this pull request Jul 25, 2024
@wangshilong @grom72
DAOS-16101 mgmt: enhanced interoperability for MGMT module (daos-stac…
3d5553b 
…k#14638)

* DAOS-16101 mgmt: enhanced interoperability for MGMT module

DAOS release 2.6 bumped mgmt RPC version because of CR feature,
This PR focuses on ensuring backward compatibility and interoperability
between DAOS version 2.4 and 2.6 for MGMT module.

Signed-off-by: Wang Shilong <shilong.wang@intel.com>
@mjmac mjmac mentioned this pull request Nov 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nasf-Fan Nasf-Fan Nasf-Fan approved these changes

@mchaarawi mchaarawi mchaarawi approved these changes

@Michael-Hennecke Michael-Hennecke Awaiting requested review from Michael-Hennecke

Assignees
No one assigned
Labels
forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. priority Ticket has high priority (automatically managed) release-2.6
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@wangshilong @daosbuild1 @mchaarawi @Nasf-Fan @Michael-Hennecke @gnailzenh