Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-16084 test: make FI required for pool/cont retry tests #14634

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

kccain
Copy link
Contributor

@kccain kccain commented Jun 24, 2024

Before this change, daos_test -p pool_op_retry() and daos_test -c co_op_retry() functions still executed even if fault injection support was disabled in the daos build. In release build testing, the tests then failed since they expected actual fault behavior on the engine side that did not get triggered.

With this change, the FAULT_INJECTION_REQUIRED() macro is invoked at the start of the test functions to skip them.

Skip-unit-tests: true
Skip-fault-injection-test: true
Test-tag: test_daos_pool test_daos_container
faults-enabled: false

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

Before this change, daos_test -p pool_op_retry() and
daos_test -c co_op_retry() functions still executed even if fault
injection support was disabled in the daos build. In release build
testing, the tests then failed since they expected actual fault
behavior on the engine side that did not get triggered.

With this change, the FAULT_INJECTION_REQUIRED() macro is
invoked at the start of the test functions to skip them.

Skip-unit-tests: true
Skip-fault-injection-test: true
Test-tag: test_daos_pool test_daos_container
faults-enabled: false

Signed-off-by: Kenneth Cain <kenneth.c.cain@intel.com>
Copy link

Ticket title is 'daos_test/suite.py:DaosCoreTest.test_daos_pool - DAOS_Pool.POOL13 src/tests/suite/daos_pool.c:776: error: Failure!'
Status is 'Open'
Labels: '2.6.0rc1,ci_impact,pr_test'
https://daosio.atlassian.net/browse/DAOS-16084

@kccain kccain added the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label Jun 25, 2024
@kccain kccain marked this pull request as ready for review June 25, 2024 18:59
@kccain kccain requested review from phender, knard38 and mchaarawi June 25, 2024 18:59
@kccain kccain requested a review from a team June 26, 2024 11:18
@kccain
Copy link
Contributor Author

kccain commented Jun 26, 2024

@daos-stack/daos-gatekeeper note the cherry-pick PR for release/2.6 branch is also ready #14644

@mchaarawi mchaarawi merged commit c3cac93 into master Jun 26, 2024
43 checks passed
@mchaarawi mchaarawi deleted the kccain/daos_16084_master branch June 26, 2024 12:44
grom72 pushed a commit to grom72/daos that referenced this pull request Jul 25, 2024
…ck#14634)

Before this change, daos_test -p pool_op_retry() and
daos_test -c co_op_retry() functions still executed even if fault
injection support was disabled in the daos build. In release build
testing, the tests then failed since they expected actual fault
behavior on the engine side that did not get triggered.

With this change, the FAULT_INJECTION_REQUIRED() macro is
invoked at the start of the test functions to skip them.

Signed-off-by: Kenneth Cain <kenneth.c.cain@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed.
Development

Successfully merging this pull request may close these issues.

4 participants