Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-16052 test: Skip wal tests if fault injection feature is disabled #14600

Merged
merged 2 commits into from
Jun 18, 2024

Conversation

wangshilong
Copy link
Contributor

some tests required fault injection, skip these tests if this feature is not enabled.

Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@wangshilong wangshilong requested review from a team as code owners June 18, 2024 02:26
Copy link

github-actions bot commented Jun 18, 2024

Ticket title is 'UTEST_VOS_md_on_ssd tests failing in 2.6 rc1 tag PR'
Status is 'In Review'
Job should run at elevated priority (1)
https://daosio.atlassian.net/browse/DAOS-16052

some tests required fault injection, skip these tests if
this feature is not enabled.

Skip-func-hw-test: true
Required-githooks: true
Signed-off-by: Wang Shilong <shilong.wang@intel.com>
NiuYawei
NiuYawei previously approved these changes Jun 18, 2024
frostedcmos
frostedcmos previously approved these changes Jun 18, 2024
@phender
Copy link
Contributor

phender commented Jun 18, 2024

I've kicked off https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-14600/3/ with BUILD_TYPE=release to verify the fix.

daltonbohning
daltonbohning previously approved these changes Jun 18, 2024
@daosbuild1
Copy link
Collaborator

Test stage NLT on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-14600/3/testReport/

Skip-func-test: true

Required-githooks: true

Signed-off-by: Phil Henderson <phillip.henderson@intel.com>
@phender phender dismissed stale reviews from daltonbohning, frostedcmos, and NiuYawei via cef3b2f June 18, 2024 16:40
@phender phender requested review from a team as code owners June 18, 2024 16:40
@github-actions github-actions bot added the priority Ticket has high priority (automatically managed) label Jun 18, 2024
@phender
Copy link
Contributor

phender commented Jun 18, 2024

https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-14600/4/ (includes Valgrind suppression; BUILD_TYPE=dev) did not report any failures but NLT timed out and aborted the build.

I've started https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-14600/5/ (includes Valgrind suppression; BUILD_TYPE=rebuild)

@phender
Copy link
Contributor

phender commented Jun 18, 2024

Build https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-14600/5/ passed w/ BUILD_TYPE=rebuild

@phender phender requested a review from a team June 18, 2024 21:05
@phender phender merged commit 5566bde into master Jun 18, 2024
47 checks passed
@phender phender deleted the shilongw/DAOS-16052 branch June 18, 2024 21:52
phender added a commit that referenced this pull request Jun 18, 2024
#14600) (#14605)

Some tests required fault injection, skip these tests if
this feature is not enabled.

Adding Valgrind suppressions.

Signed-off-by: Wang Shilong <shilong.wang@intel.com>
Signed-off-by: Phil Henderson <phillip.henderson@intel.com>
Co-authored-by: Phil Henderson <phillip.henderson@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority Ticket has high priority (automatically managed) release-2.6
Development

Successfully merging this pull request may close these issues.

6 participants