-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DAOS-16027 test: Adding daos_test REBUILD31-34 subtests #14584
Conversation
Adding rebuild tests currently not executed by doas_test/rebuild.py. Skip-unit-tests: true Skip-fault-injection-test: true Skip-func-hw-test-medium-md-on-ssd: false Test-tag: test_rebuild_31 test_rebuild_32 test_rebuild_33 test_rebuild_34 Required-githooks: true Signed-off-by: Phil Henderson <phillip.henderson@intel.com>
Ticket title is 'daos_test -r cases REBUILD31-REBUILD35 are not tested in functional testing' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we really want to add another 4 * 800s timeout (Almost an hour) to pr
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI Test-tag wrapped
Test-tag: test_rebuild_31 test_rebuild_32 test_rebuild_33
test_rebuild_34
Test stage Functional Hardware Medium MD on SSD completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14584/1/execution/node/916/log |
Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14584/1/execution/node/962/log |
@@ -66,6 +72,10 @@ daos_tests: | |||
test_rebuild_28: DAOS_Rebuild_28 | |||
test_rebuild_29: DAOS_Rebuild_29 | |||
test_rebuild_30: DAOS_Rebuild_30 | |||
test_rebuild_31: DAOS_Rebuild_31 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately test_rebuild_31 currently hangs. I discussed with @liuxuezhao and that failure is related to some overall rebuild error case handling that needs refinement, https://daosio.atlassian.net/browse/DAOS-15847.
He gave me an idea to try with test_rebuild_31 using a different type of fault injection. I can check that out separately. In the meantime, maybe we could (if the tests are able to pass) enable tests 32-35.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added skip list entries for test_rebuild_31 and test_rebuild_32.
Skip-unit-tests: true Skip-fault-injection-test: true Skip-func-hw-test-medium-md-on-ssd: false Test-tag: test_rebuild_31 test_rebuild_32 test_rebuild_33 test_rebuild_34 test_rebuild_35 Required-githooks: true Signed-off-by: Phil Henderson <phillip.henderson@intel.com>
Test stage Functional Hardware Medium MD on SSD completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14584/2/execution/node/916/log |
Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14584/2/execution/node/1014/log |
Skip-unit-tests: true Skip-fault-injection-test: true Skip-func-hw-test-medium-md-on-ssd: false Test-tag: test_rebuild_31 test_rebuild_32 test_rebuild_33 test_rebuild_34 Required-githooks: true Signed-off-by: Phil Henderson <phillip.henderson@intel.com>
Test stage Functional Hardware Medium MD on SSD completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14584/3/execution/node/916/log |
Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14584/3/execution/node/1014/log |
Skip list entries added for the new tests:
|
Skip-unit-tests: true Skip-fault-injection-test: true Skip-func-hw-test-medium-md-on-ssd: false Test-tag: test_rebuild_31 test_rebuild_32 test_rebuild_33 test_rebuild_34 Required-githooks: true Signed-off-by: Phil Henderson <phillip.henderson@intel.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we put these in daily instead of pr? this adds 4 tests * 800s each. Which is almost 1 hour for every pr
@kccain thoughts? |
Rebuild 31-32 skipped and Rebuild 33-34 passed in https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-14584/4/testReport/FTEST_daos_test/DaosCoreTestRebuild/ taking ~5.5 minutes per stage:
|
Skip-unit-tests: true Skip-fault-injection-test: true Skip-func-hw-test-medium-md-on-ssd: false Test-tag: test_rebuild_31 test_rebuild_32 test_rebuild_33 test_rebuild_34 Required-githooks: true Signed-off-by: Phil Henderson <phillip.henderson@intel.com>
Tests passing/skipping as expected in https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-14584/5/testReport/FTEST_daos_test/DaosCoreTestRebuild/ |
Adding rebuild tests currently not executed by daos_test/rebuild.py. Skip-unit-tests: true Skip-fault-injection-test: true Skip-func-hw-test-medium-md-on-ssd: false Test-tag: test_rebuild_31 test_rebuild_32 test_rebuild_33 test_rebuild_34 Signed-off-by: Phil Henderson <phillip.henderson@intel.com>
Adding rebuild tests currently not executed by doas_test/rebuild.py.
Skip-unit-tests: true
Skip-fault-injection-test: true
Skip-func-hw-test-medium-md-on-ssd: false
Test-tag: test_rebuild_31 test_rebuild_32 test_rebuild_33 test_rebuild_34
Required-githooks: true
Before requesting gatekeeper:
Features:
(orTest-tag*
) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.Gatekeeper: