Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-16027 test: Adding daos_test REBUILD31-34 subtests #14584

Merged
merged 6 commits into from
Sep 17, 2024

Conversation

phender
Copy link
Contributor

@phender phender commented Jun 14, 2024

Adding rebuild tests currently not executed by doas_test/rebuild.py.

Skip-unit-tests: true
Skip-fault-injection-test: true
Skip-func-hw-test-medium-md-on-ssd: false
Test-tag: test_rebuild_31 test_rebuild_32 test_rebuild_33 test_rebuild_34

Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

Adding rebuild tests currently not executed by doas_test/rebuild.py.

Skip-unit-tests: true
Skip-fault-injection-test: true
Skip-func-hw-test-medium-md-on-ssd: false
Test-tag: test_rebuild_31 test_rebuild_32 test_rebuild_33
test_rebuild_34

Required-githooks: true

Signed-off-by: Phil Henderson <phillip.henderson@intel.com>
@phender phender requested review from a team as code owners June 14, 2024 18:18
Copy link

github-actions bot commented Jun 14, 2024

Ticket title is 'daos_test -r cases REBUILD31-REBUILD35 are not tested in functional testing'
Status is 'In Review'
Labels: 'scrubbed_2.8,triaged,testp2'
https://daosio.atlassian.net/browse/DAOS-16027

@phender phender requested review from daltonbohning and kccain June 14, 2024 18:18
Copy link
Contributor

@daltonbohning daltonbohning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really want to add another 4 * 800s timeout (Almost an hour) to pr?

Copy link
Contributor

@daltonbohning daltonbohning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI Test-tag wrapped

Test-tag: test_rebuild_31 test_rebuild_32 test_rebuild_33
test_rebuild_34

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium MD on SSD completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14584/1/execution/node/916/log

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14584/1/execution/node/962/log

src/tests/ftest/daos_test/rebuild.yaml Show resolved Hide resolved
@@ -66,6 +72,10 @@ daos_tests:
test_rebuild_28: DAOS_Rebuild_28
test_rebuild_29: DAOS_Rebuild_29
test_rebuild_30: DAOS_Rebuild_30
test_rebuild_31: DAOS_Rebuild_31
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately test_rebuild_31 currently hangs. I discussed with @liuxuezhao and that failure is related to some overall rebuild error case handling that needs refinement, https://daosio.atlassian.net/browse/DAOS-15847.

He gave me an idea to try with test_rebuild_31 using a different type of fault injection. I can check that out separately. In the meantime, maybe we could (if the tests are able to pass) enable tests 32-35.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added skip list entries for test_rebuild_31 and test_rebuild_32.

Skip-unit-tests: true
Skip-fault-injection-test: true
Skip-func-hw-test-medium-md-on-ssd: false
Test-tag: test_rebuild_31 test_rebuild_32 test_rebuild_33
test_rebuild_34 test_rebuild_35

Required-githooks: true

Signed-off-by: Phil Henderson <phillip.henderson@intel.com>
@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium MD on SSD completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14584/2/execution/node/916/log

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14584/2/execution/node/1014/log

Skip-unit-tests: true
Skip-fault-injection-test: true
Skip-func-hw-test-medium-md-on-ssd: false
Test-tag: test_rebuild_31 test_rebuild_32 test_rebuild_33 test_rebuild_34

Required-githooks: true

Signed-off-by: Phil Henderson <phillip.henderson@intel.com>
@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium MD on SSD completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14584/3/execution/node/916/log

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14584/3/execution/node/1014/log

@phender
Copy link
Contributor Author

phender commented Sep 16, 2024

Skip list entries added for the new tests:

[['DAOS-16575', 'test_method_name', 'test_rebuild_31']]
[['DAOS-16576', 'test_method_name', 'test_rebuild_32']]

Skip-unit-tests: true
Skip-fault-injection-test: true
Skip-func-hw-test-medium-md-on-ssd: false
Test-tag: test_rebuild_31 test_rebuild_32 test_rebuild_33 test_rebuild_34

Required-githooks: true

Signed-off-by: Phil Henderson <phillip.henderson@intel.com>
Copy link
Contributor

@daltonbohning daltonbohning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we put these in daily instead of pr? this adds 4 tests * 800s each. Which is almost 1 hour for every pr

@phender
Copy link
Contributor Author

phender commented Sep 17, 2024

Can we put these in daily instead of pr? this adds 4 tests * 800s each. Which is almost 1 hour for every pr

@kccain thoughts?

@phender
Copy link
Contributor Author

phender commented Sep 17, 2024

Rebuild 31-32 skipped and Rebuild 33-34 passed in https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-14584/4/testReport/FTEST_daos_test/DaosCoreTestRebuild/ taking ~5.5 minutes per stage:

2024-09-16 20:32:28,369 test             L0530 INFO | START 1-./daos_test/rebuild.py:DaosCoreTestRebuild.test_rebuild_31;run-agent_config-transport_config-daos_tests-args-daos_test-pools_created-stopped_ranks-test_name-dmg-hosts-pool-server_config-engines-0-storage-0-1-timeouts-4b1a
2024-09-16 20:32:28,378 test             L0471 INFO | ==> Step 1: tearDown(): Called after test completion (test timeout: 1590s, elapsed: 0.01s, remaining: 1589.99s) [elapsed since last step: 0.01s]
2024-09-16 20:32:28,754 test             L0530 INFO | START 2-./daos_test/rebuild.py:DaosCoreTestRebuild.test_rebuild_32;run-agent_config-transport_config-daos_tests-args-daos_test-pools_created-stopped_ranks-test_name-dmg-hosts-pool-server_config-engines-0-storage-0-1-timeouts-4b1a
2024-09-16 20:32:28,762 test             L0471 INFO | ==> Step 1: tearDown(): Called after test completion (test timeout: 1590s, elapsed: 0.01s, remaining: 1589.99s) [elapsed since last step: 0.01s]
2024-09-16 20:32:29,139 test             L0530 INFO | START 3-./daos_test/rebuild.py:DaosCoreTestRebuild.test_rebuild_33;run-agent_config-transport_config-daos_tests-args-daos_test-pools_created-stopped_ranks-test_name-dmg-hosts-pool-server_config-engines-0-storage-0-1-timeouts-4b1a
2024-09-16 20:32:29,563 test             L0471 INFO | ==> Step 1: setUp(): Starting servers [elapsed since last step: 0.43s]
2024-09-16 20:33:20,315 test             L0471 INFO | ==> Step 2: setUp(): Starting agents [elapsed since last step: 50.75s]
2024-09-16 20:33:25,183 test             L0471 INFO | ==> Step 3: setUp(): Setup complete [elapsed since last step: 4.87s]
2024-09-16 20:34:54,204 test             L0471 INFO | ==> Step 4: tearDown(): Called after test completion (test timeout: 290s, elapsed: 145.06s, remaining: 144.94s) [elapsed since last step: 89.02s]
2024-09-16 20:34:57,237 test             L0939 INFO | PASS 3-./daos_test/rebuild.py:DaosCoreTestRebuild.test_rebuild_33;run-agent_config-transport_config-daos_tests-args-daos_test-pools_created-stopped_ranks-test_name-dmg-hosts-pool-server_config-engines-0-storage-0-1-timeouts-4b1a
2024-09-16 20:34:57,406 test             L0530 INFO | START 4-./daos_test/rebuild.py:DaosCoreTestRebuild.test_rebuild_34;run-agent_config-transport_config-daos_tests-args-daos_test-pools_created-stopped_ranks-test_name-dmg-hosts-pool-server_config-engines-0-storage-0-1-timeouts-4b1a
2024-09-16 20:34:57,841 test             L0471 INFO | ==> Step 1: setUp(): Starting servers [elapsed since last step: 0.44s]
2024-09-16 20:35:01,320 test             L0471 INFO | ==> Step 2: setUp(): Starting agents [elapsed since last step: 3.48s]
2024-09-16 20:35:01,806 test             L0471 INFO | ==> Step 3: setUp(): Destroying any existing pools before the test [elapsed since last step: 0.49s]
2024-09-16 20:35:03,002 test             L0471 INFO | ==> Step 4: setUp(): Setup complete [elapsed since last step: 1.20s]
2024-09-16 20:37:48,141 test             L0471 INFO | ==> Step 5: tearDown(): Called after test completion (test timeout: 1590s, elapsed: 170.73s, remaining: 1419.27s) [elapsed since last step: 165.14s]
2024-09-16 20:37:51,175 test             L0939 INFO | PASS 4-./daos_test/rebuild.py:DaosCoreTestRebuild.test_rebuild_34;run-agent_config-transport_config-daos_tests-args-daos_test-pools_created-stopped_ranks-test_name-dmg-hosts-pool-server_config-engines-0-storage-0-1-timeouts-4b1a

Skip-unit-tests: true
Skip-fault-injection-test: true
Skip-func-hw-test-medium-md-on-ssd: false
Test-tag: test_rebuild_31 test_rebuild_32 test_rebuild_33 test_rebuild_34

Required-githooks: true

Signed-off-by: Phil Henderson <phillip.henderson@intel.com>
@phender
Copy link
Contributor Author

phender commented Sep 17, 2024

@phender phender added the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label Sep 17, 2024
@phender phender requested a review from a team September 17, 2024 20:23
@daltonbohning daltonbohning merged commit 3e05aec into master Sep 17, 2024
47 checks passed
@daltonbohning daltonbohning deleted the pahender/DAOS-16027 branch September 17, 2024 20:27
phender added a commit that referenced this pull request Oct 5, 2024
Adding rebuild tests currently not executed by daos_test/rebuild.py.

Skip-unit-tests: true
Skip-fault-injection-test: true
Skip-func-hw-test-medium-md-on-ssd: false
Test-tag: test_rebuild_31 test_rebuild_32 test_rebuild_33 test_rebuild_34

Signed-off-by: Phil Henderson <phillip.henderson@intel.com>
daltonbohning pushed a commit that referenced this pull request Oct 9, 2024
)

Adding rebuild tests currently not executed by daos_test/rebuild.py.

Signed-off-by: Phil Henderson <phillip.henderson@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed.
Development

Successfully merging this pull request may close these issues.

4 participants