Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-15919 chk: rollback generation if failed to start checker #14577

Merged
merged 1 commit into from
Jun 24, 2024
Merged

DAOS-15919 chk: rollback generation if failed to start checker #14577

merged 1 commit into from
Jun 24, 2024

Conversation

Nasf-Fan
Copy link
Contributor

@Nasf-Fan Nasf-Fan commented Jun 14, 2024 •
edited
Loading

The chk_bookmark::cb_gen for leader may be refreshed during start checker even if the start process failed for some reason finally. Under such case, we need to recover the chk_bookmark::cb_gen back to its original value (before the failed 'chk start'); otherwise, if some former in-running instance failed current 'chk start', it will affect subsequent 'chk stop' command to stop such instance.

Test-tag: cat_recov

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@github-actions GitHub Actions
Copy link

Ticket title is 'recovery/cat_recov_core.py:CatRecovCoreTest.test_daos_cat_recov_core - CR10 DER_INVAL(-1003) != DER_SUCCESS(0)'
Status is 'In Progress'
Labels: 'ci_impact,daily_test,triaged'
https://daosio.atlassian.net/browse/DAOS-15919

@Nasf-Fan
DAOS-15919 chk: rollback generation if failed to start checker
98f4126 
The chk_bookmark::cb_gen for leader may be refreshed during start
checker even if the start process failed for some reason finally.
Under such case, we need to recover the chk_bookmark::cb_gen back
to its original value (before the failed 'chk start'); otherwise,
if some former in-running instance failed current 'chk start', it
will affect subsequent 'chk stop' command to stop such instance.

Test-tag: cat_recov

Signed-off-by: Fan Yong <fan.yong@intel.com>
@Nasf-Fan Nasf-Fan force-pushed the Nasf-Fan/DAOS-15919_1 branch from 3309553 to 98f4126 Compare June 14, 2024 03:51
@Nasf-Fan Nasf-Fan marked this pull request as ready for review June 18, 2024 03:34
@Nasf-Fan Nasf-Fan requested review from liw and kjacque June 18, 2024 03:35
@Nasf-Fan Nasf-Fan requested a review from a team June 19, 2024 01:48
@Nasf-Fan
Copy link
Contributor Author

Ping @daos-stack/daos-gatekeeper , thanks

@Nasf-Fan
Copy link
Contributor Author

Ping @daos-stack/daos-gatekeeper , thanks!

@daltonbohning daltonbohning merged commit c8ebba0 into master Jun 24, 2024
49 of 50 checks passed
@daltonbohning daltonbohning deleted the Nasf-Fan/DAOS-15919_1 branch June 24, 2024 17:31
@daltonbohning daltonbohning added the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label Jun 24, 2024
grom72 pushed a commit to grom72/daos that referenced this pull request Jul 25, 2024
@Nasf-Fan @grom72
DAOS-15919 chk: rollback generation if failed to start checker (daos-…
021b493 
…stack#14577)

The chk_bookmark::cb_gen for leader may be refreshed during start
checker even if the start process failed for some reason finally.
Under such case, we need to recover the chk_bookmark::cb_gen back
to its original value (before the failed 'chk start'); otherwise,
if some former in-running instance failed current 'chk start', it
will affect subsequent 'chk stop' command to stop such instance.

Signed-off-by: Fan Yong <fan.yong@intel.com>
@mjmac mjmac mentioned this pull request Nov 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjacque kjacque kjacque approved these changes

@liw liw liw approved these changes

Assignees
No one assigned
Labels
forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Nasf-Fan @liw @kjacque @daltonbohning