Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-13994 test: variants for performance pil4dfs #14533

Merged
merged 1 commit into from
Jun 24, 2024
Merged

DAOS-13994 test: variants for performance pil4dfs #14533

merged 1 commit into from
Jun 24, 2024

Conversation

daltonbohning
Copy link
Contributor

Add performance variants for dfuse + libpil4dfs.
Add some variants for mpiio and hdf5.
Removed unused variants.

Test-tag: performance
Skip-unit-tests: true
Skip-fault-injection-test: true

Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@daltonbohning daltonbohning self-assigned this Jun 7, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 7, 2024 •
edited
Loading

Ticket title is 'ftest: support performance pil4dfs'
Status is 'In Review'
Labels: 'tds'
https://daosio.atlassian.net/browse/DAOS-13994

@daltonbohning daltonbohning mentioned this pull request Jun 7, 2024
Closed
18 tasks
@daltonbohning daltonbohning force-pushed the dbohning/daos-13994-2 branch 7 times, most recently from a69e4dd to 02f3114 Compare June 13, 2024 16:04
@daltonbohning
DAOS-13944 test: variants for performance pil4dfs
19dc1b0 
Add performance variants for dfuse + libpil4dfs.
Add some variants for mpiio and hdf5.
Removed unused variants.

Test-tag: performance BasicCheckout
Skip-unit-tests: true
Skip-fault-injection-test: true

Required-githooks: true

Signed-off-by: Dalton Bohning <dalton.bohning@intel.com>
@daltonbohning daltonbohning force-pushed the dbohning/daos-13994-2 branch from 02f3114 to 19dc1b0 Compare June 13, 2024 17:00
@daltonbohning daltonbohning marked this pull request as ready for review June 17, 2024 22:52
@daltonbohning daltonbohning requested review from a team as code owners June 17, 2024 22:52
@daltonbohning daltonbohning changed the title DAOS-13944 test: variants for performance pil4dfs DAOS-13994 test: variants for performance pil4dfs Jun 17, 2024
@daltonbohning daltonbohning requested a review from a team June 20, 2024 19:05
@daltonbohning daltonbohning added the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label Jun 20, 2024
@daltonbohning daltonbohning merged commit 2cffb26 into master Jun 24, 2024
45 checks passed
@daltonbohning daltonbohning deleted the dbohning/daos-13994-2 branch June 24, 2024 20:31
daltonbohning added a commit that referenced this pull request Jun 25, 2024
@daltonbohning
DAOS-13944 test: variants for performance pil4dfs (#14533)
cb31bbe 
Test-tag: performance BasicCheckout
Skip-unit-tests: true
Skip-fault-injection-test: true

Add performance variants for dfuse + libpil4dfs.
Add some variants for mpiio and hdf5.
Removed unused variants.

Required-githooks: true

Signed-off-by: Dalton Bohning <dalton.bohning@intel.com>
daltonbohning added a commit that referenced this pull request Jun 25, 2024
@daltonbohning
DAOS-13944 test: variants for performance pil4dfs (#14533)
44ae646 
Test-tag: performance BasicCheckout
Skip-unit-tests: true
Skip-fault-injection-test: true

Add performance variants for dfuse + libpil4dfs.
Add some variants for mpiio and hdf5.
Removed unused variants.

Required-githooks: true

Signed-off-by: Dalton Bohning <dalton.bohning@intel.com>
phender pushed a commit that referenced this pull request Jun 27, 2024
@daltonbohning
DAOS-13944 test: variants for performance pil4dfs (#14533) (#14643)
b6233b4 
Add performance variants for dfuse + libpil4dfs.
Add some variants for mpiio and hdf5.
Removed unused variants.

Signed-off-by: Dalton Bohning <dalton.bohning@intel.com>
grom72 pushed a commit to grom72/daos that referenced this pull request Jul 25, 2024
@daltonbohning @grom72
DAOS-13944 test: variants for performance pil4dfs (daos-stack#14533)
5b544ad 
Add performance variants for dfuse + libpil4dfs.
Add some variants for mpiio and hdf5.
Removed unused variants.

Signed-off-by: Dalton Bohning <dalton.bohning@intel.com>
@mjmac mjmac mentioned this pull request Nov 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phender phender phender approved these changes

@shimizukko shimizukko shimizukko approved these changes

@rpadma2 rpadma2 Awaiting requested review from rpadma2

Assignees

@daltonbohning daltonbohning

Labels
forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@daltonbohning @shimizukko @phender