Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-15955 test: increase clush fanout for run_remote #14509

Merged
merged 1 commit into from
Jun 13, 2024
Merged

DAOS-15955 test: increase clush fanout for run_remote #14509

merged 1 commit into from
Jun 13, 2024

Conversation

daltonbohning
Copy link
Contributor

Set clush fanout in run_remote to the max of the default or number of logical cores. This will help in large-scale environments.

Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@daltonbohning daltonbohning self-assigned this Jun 4, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 4, 2024

Ticket title is 'ftest: use larger fanout with clush'
Status is 'Open'
https://daosio.atlassian.net/browse/DAOS-15955

@daltonbohning daltonbohning force-pushed the dbohning/daos-15955 branch from a468c09 to d549778 Compare June 4, 2024 22:49
@daosbuild1
Copy link
Collaborator

Test stage NLT on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-14509/2/testReport/

@daltonbohning daltonbohning force-pushed the dbohning/daos-15955 branch 4 times, most recently from b29ec54 to 9e79095 Compare June 7, 2024 17:40
@daltonbohning
DAOS-15955 test: increase clush fanout for run_remote
bbbbb19 
Features: soak_smoke
Skip-unit-tests: true
Skip-fault-injection-test: true

Set clush fanout in run_remote to the max of the default or number
of logical cores. This will help in large-scale environments.

Required-githooks: true

Signed-off-by: Dalton Bohning <dalton.bohning@intel.com>
@daltonbohning daltonbohning force-pushed the dbohning/daos-15955 branch from 9e79095 to bbbbb19 Compare June 7, 2024 17:54
@daltonbohning daltonbohning marked this pull request as ready for review June 10, 2024 21:42
@daltonbohning daltonbohning requested review from a team as code owners June 10, 2024 21:42
saurabhtandan
saurabhtandan approved these changes Jun 13, 2024
View reviewed changes
Copy link
Contributor

@saurabhtandan saurabhtandan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phender phender merged commit a4610e8 into master Jun 13, 2024
46 checks passed
@phender phender deleted the dbohning/daos-15955 branch June 13, 2024 18:04
daltonbohning added a commit that referenced this pull request Jun 14, 2024
@daltonbohning
DAOS-15955 test: increase clush fanout for run_remote (#14509)
4a987e1 
Features: soak_smoke
Skip-unit-tests: true
Skip-fault-injection-test: true

Set clush fanout in run_remote to the max of the default or number
of logical cores. This will help in large-scale environments.

Required-githooks: true

Signed-off-by: Dalton Bohning <dalton.bohning@intel.com>
daltonbohning added a commit that referenced this pull request Jun 14, 2024
@daltonbohning
DAOS-15955 test: increase clush fanout for run_remote (#14509)
6a7ef07 
Features: soak_smoke
Skip-unit-tests: true
Skip-fault-injection-test: true

Set clush fanout in run_remote to the max of the default or number
of logical cores. This will help in large-scale environments.

Required-githooks: true

Signed-off-by: Dalton Bohning <dalton.bohning@intel.com>
mjean308 pushed a commit that referenced this pull request Jun 18, 2024
@daltonbohning @mjean308
DAOS-15955 test: increase clush fanout for run_remote (#14509)
7257ae1 
Features: soak_smoke
Skip-unit-tests: true
Skip-fault-injection-test: true

Set clush fanout in run_remote to the max of the default or number
of logical cores. This will help in large-scale environments.

Required-githooks: true

Signed-off-by: Dalton Bohning <dalton.bohning@intel.com>
daltonbohning added a commit that referenced this pull request Jun 18, 2024
@daltonbohning
DAOS-15955 test: increase clush fanout for run_remote (#14509)
1ff2363 
Features: soak_smoke
Skip-unit-tests: true
Skip-fault-injection-test: true

Set clush fanout in run_remote to the max of the default or number
of logical cores. This will help in large-scale environments.

Required-githooks: true

Signed-off-by: Dalton Bohning <dalton.bohning@intel.com>
daltonbohning added a commit that referenced this pull request Jun 20, 2024
@daltonbohning
DAOS-15955 test: increase clush fanout for run_remote (#14509)
c3d5086 
Features: soak_smoke
Skip-unit-tests: true
Skip-fault-injection-test: true

Set clush fanout in run_remote to the max of the default or number
of logical cores. This will help in large-scale environments.

Required-githooks: true

Signed-off-by: Dalton Bohning <dalton.bohning@intel.com>
phender pushed a commit that referenced this pull request Jun 25, 2024
@daltonbohning
DAOS-15955 test: increase clush fanout for run_remote (#14509) (#14581)
88859e4 
Set clush fanout in run_remote to the max of the default or number
of logical cores. This will help in large-scale environments.

Signed-off-by: Dalton Bohning <dalton.bohning@intel.com>
@mjmac mjmac mentioned this pull request Nov 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phender phender phender approved these changes

@rpadma2 rpadma2 rpadma2 approved these changes

@saurabhtandan saurabhtandan saurabhtandan approved these changes

@mjean308 mjean308 Awaiting requested review from mjean308

Assignees

@daltonbohning daltonbohning

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@daltonbohning @daosbuild1 @saurabhtandan @rpadma2 @phender