Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-15953 test: update online_drain to use config values #14498

Merged
merged 1 commit into from
Jul 24, 2024
Merged

DAOS-15953 test: update online_drain to use config values #14498

merged 1 commit into from
Jul 24, 2024

Conversation

daltonbohning
Copy link
Contributor

Test-repeat: 2
Skip-unit-tests: true
Skip-fault-injection-test: true

Get the targets and ranks from the config instead of hardcoding. Also use self.random instead of direct random.

Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 3, 2024 •
edited
Loading

Ticket title is 'ftest/osa/online_drain.py should not hardcode 2 engines'
Status is 'In Progress'
Labels: 'scrubbed_2.8'
https://daosio.atlassian.net/browse/DAOS-15953

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14498/2/execution/node/914/log

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium MD on SSD completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14498/2/execution/node/1012/log

@daltonbohning daltonbohning force-pushed the dbohning/daos-15953 branch from a0d3451 to 0bcf6fd Compare June 5, 2024 15:58
@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-14498/3/testReport/

@daltonbohning daltonbohning force-pushed the dbohning/daos-15953 branch from 0bcf6fd to fc278cf Compare June 6, 2024 22:03
@daltonbohning
DAOS-15953 test: update online_drain to use config values
f6f3d74 
Test-repeat: 3
Skip-unit-tests: true
Skip-fault-injection-test: true

Get the targets and ranks from the config instead of hardcoding.
Also use self.random instead of direct random.

Required-githooks: true

Signed-off-by: Dalton Bohning <dalton.bohning@intel.com>
@daltonbohning daltonbohning marked this pull request as ready for review July 23, 2024 13:28
@daltonbohning daltonbohning requested review from a team as code owners July 23, 2024 13:28
@daltonbohning
Copy link
Contributor Author

Test passed 3 times:
https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-14498/6/testReport/FTEST_osa/OSAOnlineDrain/

And 3 times before that:
https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-14498/5/testReport/FTEST_osa/OSAOnlineDrain/

@daltonbohning daltonbohning requested a review from a team July 24, 2024 14:57
@daltonbohning daltonbohning added the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label Jul 24, 2024
@phender phender merged commit 00e564e into master Jul 24, 2024
44 checks passed
@phender phender deleted the dbohning/daos-15953 branch July 24, 2024 21:53
@mjmac mjmac mentioned this pull request Nov 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rpadma2 rpadma2 rpadma2 approved these changes

@shimizukko shimizukko shimizukko approved these changes

@phender phender Awaiting requested review from phender

Assignees
No one assigned
Labels
forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@daltonbohning @daosbuild1 @shimizukko @rpadma2 @phender