Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-15498 rebuild: reprobe in migrate_obj_iter_cb #14458

Merged
merged 1 commit into from
May 30, 2024

Conversation

liuxuezhao
Copy link
Contributor

@liuxuezhao liuxuezhao commented May 28, 2024

migrate_system_enter possibly will yield, so need to do a re-probe before delete.

Test-tag: test_osa_offline_drain_after_snapshot
Test-repeat: 10

Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

Copy link

Ticket title is 'osa/offline_drain.py:OSAOfflineDrain.test_osa_offline_drain_after_snapshot - dfs_open() of testfile.00000013 Failed'
Status is 'In Progress'
Labels: 'ci_impact,daily_test,triaged'
https://daosio.atlassian.net/browse/DAOS-15498

@liuxuezhao liuxuezhao force-pushed the lxz/rebuild_tree_fix branch from e407b0c to f8b26c6 Compare May 28, 2024 23:07
migrate_system_enter possibly will yield, so need to do a re-probe
before delete.

Test-tag: test_osa_offline_drain_after_snapshot
Test-repeat: 10

Required-githooks: true

Signed-off-by: Xuezhao Liu <xuezhao.liu@intel.com>
@liuxuezhao liuxuezhao force-pushed the lxz/rebuild_tree_fix branch from f8b26c6 to bed8ca6 Compare May 28, 2024 23:22
@daosbuild1
Copy link
Collaborator

Test stage Test RPMs on EL 8.6 completed with status FAILURE. https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-14458/6/display/redirect

@daosbuild1
Copy link
Collaborator

Test stage Unit Test bdev with memcheck on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-14458/7/display/redirect

@liuxuezhao liuxuezhao marked this pull request as ready for review May 29, 2024 08:53
@liuxuezhao liuxuezhao requested review from a team as code owners May 29, 2024 08:53
@liuxuezhao liuxuezhao requested review from NiuYawei, Nasf-Fan, kccain and gnailzenh and removed request for a team May 29, 2024 08:53
@liuxuezhao liuxuezhao requested a review from a team May 29, 2024 09:40
@liuxuezhao liuxuezhao requested review from a team and removed request for a team May 30, 2024 01:20
@gnailzenh gnailzenh merged commit fd7c5e9 into master May 30, 2024
49 of 50 checks passed
@gnailzenh gnailzenh deleted the lxz/rebuild_tree_fix branch May 30, 2024 12:46
liuxuezhao added a commit that referenced this pull request May 30, 2024
migrate_system_enter possibly will yield, so need to do a re-probe
before delete.

Required-githooks: true

Signed-off-by: Xuezhao Liu <xuezhao.liu@intel.com>
gnailzenh pushed a commit that referenced this pull request Jun 3, 2024
migrate_system_enter possibly will yield, so need to do a re-probe
before delete.

Signed-off-by: Xuezhao Liu <xuezhao.liu@intel.com>
jolivier23 pushed a commit that referenced this pull request Jun 3, 2024
migrate_system_enter possibly will yield, so need to do a re-probe
before delete.

Signed-off-by: Xuezhao Liu <xuezhao.liu@intel.com>
jolivier23 added a commit that referenced this pull request Jun 3, 2024
migrate_system_enter possibly will yield, so need to do a re-probe
before delete.

Signed-off-by: Xuezhao Liu <xuezhao.liu@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants