Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SRE-2229 utils: Replace /bin/sh with /bin/bash in githooks #14457

Merged
merged 1 commit into from
May 29, 2024

Conversation

jzarzycki
Copy link
Contributor

@jzarzycki jzarzycki commented May 28, 2024

Fixed an issue where /bin/sh pointing to /bin/dash instead of /bin/bash was breaking compatibility on Ubuntu 22.04

Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

Fixed an issue where /bin/sh pointing to /bin/dash instead of /bin/bash was causing issues on ubuntu 22.04

Required-githooks: true

Signed-off-by: Jan Zarzycki <jan.zarzycki@intel.com>
Copy link

Errors are Unable to load ticket data
https://daosio.atlassian.net/browse/SRE-2229

@jzarzycki jzarzycki removed the request for review from ashleypittman May 29, 2024 07:01
@jzarzycki jzarzycki self-assigned this May 29, 2024
@jzarzycki jzarzycki requested a review from a team May 29, 2024 07:09
Copy link
Contributor

@daltonbohning daltonbohning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normally we need to wait for testing to complete before requesting gatekeeper:
https://build.hpdd.intel.com/blue/organizations/jenkins/daos-stack%2Fdaos/detail/PR-14457/1/pipeline

But since this PR only modifies githooks, we don't actually need those HW stages so I will land this now to save the CI resources.

@daltonbohning daltonbohning merged commit 1d41e05 into master May 29, 2024
54 of 55 checks passed
@daltonbohning daltonbohning deleted the jzarzyck/SRE-2229-githooks-fix branch May 29, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants