Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-15885 vos: check DTX visibility when probe for EV iteration #14418

Merged
merged 1 commit into from
Jun 5, 2024
Merged

DAOS-15885 vos: check DTX visibility when probe for EV iteration #14418

merged 1 commit into from
Jun 5, 2024

Conversation

Nasf-Fan
Copy link
Contributor

To avoid locating the iteration position (for the first time) on some invisible EV data (with in-processing or aborted DTX).

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@github-actions GitHub Actions
Copy link

Ticket title is 'EV probe miss to check DTX status'
Status is 'In Progress'
https://daosio.atlassian.net/browse/DAOS-15885

@daosbuild1
Copy link
Collaborator

Test stage Unit Test on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-14418/1/testReport/

@daosbuild1
Copy link
Collaborator

Test stage Unit Test bdev on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-14418/1/testReport/

@daosbuild1
Copy link
Collaborator

Test stage NLT on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14418/1/execution/node/814/log

@daosbuild1
Copy link
Collaborator

Test stage Unit Test with memcheck on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-14418/1/testReport/

@daosbuild1
Copy link
Collaborator

Test stage Unit Test bdev with memcheck on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-14418/1/testReport/

@Nasf-Fan Nasf-Fan force-pushed the Nasf-Fan/DAOS-15885 branch from 62920fb to c8e154c Compare May 23, 2024 03:59
@daosbuild1
Copy link
Collaborator

Test stage Unit Test on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-14418/2/testReport/

@daosbuild1
Copy link
Collaborator

Test stage Unit Test bdev on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-14418/2/testReport/

@daosbuild1
Copy link
Collaborator

Test stage NLT on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14418/2/execution/node/814/log

@daosbuild1
Copy link
Collaborator

Test stage Unit Test bdev with memcheck on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-14418/2/testReport/

@daosbuild1
Copy link
Collaborator

Test stage Unit Test with memcheck on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-14418/2/testReport/

@Nasf-Fan Nasf-Fan force-pushed the Nasf-Fan/DAOS-15885 branch 4 times, most recently from ff532be to c4267ee Compare May 24, 2024 08:34
@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14418/6/execution/node/1424/log

@Nasf-Fan
Copy link
Contributor Author

scrubber/target_auto_eviction.py failed for DAOS-14585, not related with the patch, to be retested.

@Nasf-Fan Nasf-Fan force-pushed the Nasf-Fan/DAOS-15885 branch from c4267ee to 14d43dc Compare May 26, 2024 04:17
@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium UCX Provider completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14418/8/execution/node/1411/log

@Nasf-Fan Nasf-Fan force-pushed the Nasf-Fan/DAOS-15885 branch from 14d43dc to 94a9cc8 Compare May 28, 2024 05:00
@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-14418/9/display/redirect

@Nasf-Fan
DAOS-15885 vos: check DTX visibility when probe for EV iteration
7621d24 
To avoid locating the iteration position (for the first time) on
some invisible EV data (with in-processing or aborted DTX).

Allow-unstable-test: true

Signed-off-by: Fan Yong <fan.yong@intel.com>
@Nasf-Fan Nasf-Fan force-pushed the Nasf-Fan/DAOS-15885 branch from 94a9cc8 to 7621d24 Compare May 29, 2024 02:03
@Nasf-Fan Nasf-Fan marked this pull request as ready for review May 30, 2024 15:08
@Nasf-Fan Nasf-Fan requested review from a team as code owners May 30, 2024 15:08
@Nasf-Fan Nasf-Fan requested review from janekmi and jolivier23 May 30, 2024 15:09
@Nasf-Fan Nasf-Fan requested review from gnailzenh and NiuYawei May 31, 2024 08:27
@Nasf-Fan Nasf-Fan requested a review from a team June 3, 2024 05:46
@jolivier23 jolivier23 merged commit 0675a6c into master Jun 5, 2024
51 of 52 checks passed
@jolivier23 jolivier23 deleted the Nasf-Fan/DAOS-15885 branch June 5, 2024 14:36
@mjmac mjmac mentioned this pull request Nov 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jolivier23 jolivier23 jolivier23 approved these changes

@NiuYawei NiuYawei NiuYawei approved these changes

@janekmi janekmi Awaiting requested review from janekmi

@gnailzenh gnailzenh Awaiting requested review from gnailzenh

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Nasf-Fan @daosbuild1 @NiuYawei @jolivier23