Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-15884 cart: Cleanup #14417

Merged
merged 9 commits into from
May 29, 2024
Merged

DAOS-15884 cart: Cleanup #14417

merged 9 commits into from
May 29, 2024

Conversation

frostedcmos
Copy link
Contributor

crt_launch now correctly sets D_PORT instead of deprecated OFI_PORT self_test client:

  • For non-daos usage (no agent), use default 0:0 endpoint instead of 0:2, as cart-level sample engines might not have tag=2, but are guaranteed to have at least 1 context
  • Remove deprecated singleton and nopmix options

Other:

  • Remove crt_phy_addr_t, replace with char*
  • Remove CRT_PHY_ADDR_ENV, OFI_PORT, OFI_DOMAIN, OFI_INTERFACE
  • Remove sep related stuff
  • Remove unimplemented crt_group_info_set/get

Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

crt_launch now correctly sets D_PORT instead of deprecated OFI_PORT
self_test client:
 - For non-daos usage (no agent), use default 0:0 endpoint instead of 0:2, as cart-level
   sample engines might not have tag=2, but are guaranteed to have at least 1 context
 - Remove deprecated singleton and nopmix options

Other:
- Remove crt_phy_addr_t, replace with char*
- Remove CRT_PHY_ADDR_ENV, OFI_PORT, OFI_DOMAIN, OFI_INTERFACE
- Remove sep related stuff
- Remove unimplemented crt_group_info_set/get

Required-githooks: true

Signed-off-by: Alexander A Oganezov <alexander.a.oganezov@intel.com>
@frostedcmos frostedcmos requested review from a team as code owners May 22, 2024 05:53
Copy link

Ticket title is 'Cart cleanup post 2.6'
Status is 'Open'
https://daosio.atlassian.net/browse/DAOS-15884

@daosbuild1
Copy link
Collaborator

Test stage Build on Leap 15.5 with Intel-C and TARGET_PREFIX completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14417/1/execution/node/371/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on EL 9 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14417/1/execution/node/359/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on EL 8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14417/1/execution/node/327/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on Leap 15.5 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14417/1/execution/node/360/log

@daosbuild1
Copy link
Collaborator

Test stage Build DEB on Ubuntu 20.04 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14417/1/execution/node/367/log

Required-githooks: true

Signed-off-by: Alexander A Oganezov <alexander.a.oganezov@intel.com>
Copy link
Contributor

@daltonbohning daltonbohning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ftest LGTM

Copy link
Collaborator

@soumagne soumagne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me but you should fix the clang format (from the env var list).

Required-githooks: true

Signed-off-by: Alexander A Oganezov <alexander.a.oganezov@intel.com>
Required-githooks: true

Signed-off-by: Alexander A Oganezov <alexander.a.oganezov@intel.com>
Required-githooks: true

Signed-off-by: Alexander A Oganezov <alexander.a.oganezov@intel.com>
@frostedcmos
Copy link
Contributor Author

looks good to me but you should fix the clang format (from the env var list).

tried few different formats, including local formatting suggested by clang itself, but each time it is unhappy. so not sure what format to change this to

Required-githooks: true

Signed-off-by: Jerome Soumagne <jerome.soumagne@intel.com>
@daosbuild1
Copy link
Collaborator

Test stage NLT on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-14417/6/display/redirect

Required-githooks: true

Signed-off-by: Alexander A Oganezov <alexander.a.oganezov@intel.com>
@frostedcmos frostedcmos requested a review from mchaarawi May 29, 2024 01:48
@frostedcmos frostedcmos requested a review from a team May 29, 2024 15:41
@phender phender merged commit f39b1b5 into master May 29, 2024
50 of 52 checks passed
@phender phender deleted the aaoganez/post-2.6-cleanup branch May 29, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

6 participants