-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DAOS-15884 cart: Cleanup #14417
DAOS-15884 cart: Cleanup #14417
Conversation
crt_launch now correctly sets D_PORT instead of deprecated OFI_PORT self_test client: - For non-daos usage (no agent), use default 0:0 endpoint instead of 0:2, as cart-level sample engines might not have tag=2, but are guaranteed to have at least 1 context - Remove deprecated singleton and nopmix options Other: - Remove crt_phy_addr_t, replace with char* - Remove CRT_PHY_ADDR_ENV, OFI_PORT, OFI_DOMAIN, OFI_INTERFACE - Remove sep related stuff - Remove unimplemented crt_group_info_set/get Required-githooks: true Signed-off-by: Alexander A Oganezov <alexander.a.oganezov@intel.com>
Ticket title is 'Cart cleanup post 2.6' |
Test stage Build on Leap 15.5 with Intel-C and TARGET_PREFIX completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14417/1/execution/node/371/log |
Test stage Build RPM on EL 9 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14417/1/execution/node/359/log |
Test stage Build RPM on EL 8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14417/1/execution/node/327/log |
Test stage Build RPM on Leap 15.5 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14417/1/execution/node/360/log |
Test stage Build DEB on Ubuntu 20.04 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14417/1/execution/node/367/log |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ftest LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me but you should fix the clang format (from the env var list).
tried few different formats, including local formatting suggested by clang itself, but each time it is unhappy. so not sure what format to change this to |
Required-githooks: true Signed-off-by: Jerome Soumagne <jerome.soumagne@intel.com>
Test stage NLT on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-14417/6/display/redirect |
Required-githooks: true Signed-off-by: Alexander A Oganezov <alexander.a.oganezov@intel.com>
…s into aaoganez/post-2.6-cleanup
crt_launch now correctly sets D_PORT instead of deprecated OFI_PORT self_test client:
Other:
Required-githooks: true
Before requesting gatekeeper:
Features:
(orTest-tag*
) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.Gatekeeper: