DAOS-15873 test: Fix wal checkpoint metric test #14416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When verifying the wal checkpoint metrics after check pointing has occurred, make sure to use a case-insensitive match of the UUID of the pool for which the metrics are expected to have changed. Skip-unit-tests: true Skip-fault-injection-test: true Skip-func-hw-test-medium-md-on-ssd: false Test-repeat: 3 Test-tag: test_wal_checkpoint_metrics Required-githooks: true Signed-off-by: Phil Henderson <phillip.henderson@intel.com>
|
Ticket title is 'telemetry/wal_metrics.py:WalMetrics.test_wal_checkpoint_metrics - validation of metrics after checkpointing is incorrect' |
daltonbohning
approved these changes
May 22, 2024
| if '_wal_purged' in metric: | ||
| # Check point wal purged should be > 0 after check point for MD on SSD | ||
| if pool.uuid.casefold() in label.casefold(): | ||
| # After check pointing has occurred for a pool with for MD on SSD |
There was a problem hiding this comment.
Suggested change
| # After check pointing has occurred for a pool with for MD on SSD | |
| # After check pointing has occurred for a pool with MD on SSD |
|
Test passed 3 times w/ PMEM and MD on SSD: https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-14416/1/testReport/FTEST_telemetry/WalMetrics/ |
dinghwah
approved these changes
May 23, 2024
phender
added
the
forced-landing
phender
added a commit
that referenced
this pull request
May 23, 2024
When verifying the wal checkpoint metrics after check pointing has occurred, make sure to use a case-insensitive match of the UUID of the pool for which the metrics are expected to have changed. Skip-unit-tests: true Skip-fault-injection-test: true Skip-func-hw-test-medium-md-on-ssd: false Test-tag: test_wal_checkpoint_metrics Signed-off-by: Phil Henderson <phillip.henderson@intel.com>
phender
added a commit
that referenced
this pull request
May 24, 2024
When verifying the wal checkpoint metrics after check pointing has occurred, make sure to use a case-insensitive match of the UUID of the pool for which the metrics are expected to have changed. Signed-off-by: Phil Henderson <phillip.henderson@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When verifying the wal checkpoint metrics after check pointing has occurred, make sure to use a case-insensitive match of the UUID of the pool for which the metrics are expected to have changed.
Skip-unit-tests: true
Skip-fault-injection-test: true
Skip-func-hw-test-medium-md-on-ssd: false
Test-repeat: 3
Test-tag: test_wal_checkpoint_metrics
Required-githooks: true
Before requesting gatekeeper:
Features:(orTest-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.Gatekeeper: