Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-15834 client: disable interception before exec() #14405

Merged
merged 1 commit into from
May 22, 2024
Merged

DAOS-15834 client: disable interception before exec() #14405

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/client/dfuse/pil4dfs/int_dfs.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4318,6 +4318,8 @@ reset_daos_env_before_exec(void)
d_daos_inited = false;
daos_debug_inited = false;
context_reset = false;
/* all IO requests go through dfuse */
d_hook_enabled = false;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are there any open pool/container handles that need to be cleaned up here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
Normally bash creates child process with fork(), then call exec() to start a new application shortly. It probably is rare to open a new DFS container between fork() and exec().
I can address this issue in a follow up PR. We need to save the current pid when daos_pool_connect() and daos_cont_open() are called. We can close pool/container handles before exec() if they are opened by current process.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, yes, this only affect time between fork and exec so you're right, it's likely rare to non-existent. Apps that exec are probably doing nothing between fork and exec.

}
return 0;
}
Expand Down
Loading