Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide workaround for SPDK issue 2683, AMD iommu support #14166

Merged
merged 2 commits into from
May 29, 2024

Conversation

krehm
Copy link
Contributor

@krehm krehm commented Apr 16, 2024

In SPDK issue 2683, SPDK incorrectly determines that an AMD iommu does not support virtual addressing. As a result, DAOS engines cannot run as non-root on an AMD server. Change DAOS to specify iova_mode = "va" when calling spdk_env_init() when running as non-root. This is a workaround until SPDK issue 2683 is fixed.

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@krehm krehm requested review from a team as code owners April 16, 2024 15:03
Copy link

Errors are component not formatted correctly,Ticket number prefix incorrect,PR title is malformatted. See https://daosio.atlassian.net/wiki/spaces/DC/pages/11133911069/Commit+Comments,Unable to load ticket data
https://daosio.atlassian.net/browse/Provide

In SPDK issue 2683, SPDK incorrectly determines that an AMD iommu
does not support virtual addressing.  As a result, DAOS engines
cannot run as non-root on an AMD server.  Change DAOS to specify
iova_mode = "va" when calling spdk_env_init() when running as
non-root.  This is a workaround until SPDK issue 2683 is fixed.

Signed-off-by: Kevan Rehm <kevan.rehm@hpe.com>
Replace several tabs with spaces.

Signed-off-by: Kevan Rehm <kevan.rehm@hpe.com>
Copy link
Contributor

@tanabarr tanabarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, adding @NiuYawei and @jolivier23 who have had exposure to this kind of issue before.

@tanabarr tanabarr requested review from jolivier23 and NiuYawei April 17, 2024 15:59
@johannlombardi
Copy link
Contributor

Thanks @krehm. Tested on my AMD node and it works.

@johannlombardi johannlombardi merged commit 7ab7e88 into daos-stack:master May 29, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants