Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-15548 test: add new valgrind suppression for daos tool #14081

Merged
merged 1 commit into from
Mar 28, 2024
Merged

DAOS-15548 test: add new valgrind suppression for daos tool #14081

merged 1 commit into from
Mar 28, 2024

Conversation

mchaarawi
Copy link
Contributor

Skip-func-test: true

Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@mchaarawi
DAOS-15548 test: add new valgrind suppression for daos tool
136e7e6 
Skip-func-test: true

Required-githooks: true

Signed-off-by: Mohamad Chaarawi <mohamad.chaarawi@intel.com>
@github-actions GitHub Actions
Copy link

Ticket title is 'Unit Tests / NLT on EL 8.8 / NLT.core.container list NLT- valgrind failures'
Status is 'Open'
https://daosio.atlassian.net/browse/DAOS-15548

@mchaarawi mchaarawi marked this pull request as ready for review March 28, 2024 13:39
@mchaarawi mchaarawi requested review from a team as code owners March 28, 2024 13:39
knard-intel
knard-intel approved these changes Mar 28, 2024
View reviewed changes
Copy link
Contributor

@knard-intel knard-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from my understanding.

@mchaarawi mchaarawi merged commit 0ffd241 into master Mar 28, 2024
44 checks passed
@mchaarawi mchaarawi deleted the mschaara/15548 branch March 28, 2024 13:44
jolivier23 pushed a commit that referenced this pull request Apr 16, 2024
@mchaarawi @jolivier23
DAOS-15548 test: add new valgrind suppression for daos tool (#14081)
b8ce6c4 
Signed-off-by: Mohamad Chaarawi <mohamad.chaarawi@intel.com>
jolivier23 pushed a commit that referenced this pull request Apr 16, 2024
@mchaarawi @jolivier23
DAOS-15548 test: add new valgrind suppression for daos tool (#14081)
5915a99 
Signed-off-by: Mohamad Chaarawi <mohamad.chaarawi@intel.com>
jolivier23 added a commit that referenced this pull request Apr 17, 2024
@jolivier23
b/334920724 - Fix google/2.4 pylint issues (#14162)
a6bac14 
disable CODEOWNERS for google branch
disable upstream hardware tests on branch by default
remove bad merge block
fix ordering of imports
Rename google-changeId.py
set option for dynamic fuse

Backports included here for test fixes
DAOS-15429 test: Fix Go unit tests (#13981)
DAOS-13490 test: Update valgrind suppressions. (#13142)
DAOS-15159 test: add a supression for new valgrind warning in NLT (#13782)
DAOS-14669 test: switch tcp;ofi_rxm testing to tcp (#13365)
DAOS-15548 test: add new valgrind suppression for daos tool (#14081)

Signed-off-by: Jeff Olivier <jeffolivier@google.com>
Signed-off-by: Michael MacDonald <mjmac@google.com>
Signed-off-by: Ashley Pittman <ashley.m.pittman@intel.com>
Signed-off-by: Mohamad Chaarawi <mohamad.chaarawi@intel.com>
Signed-off-by: Jerome Soumagne <jerome.soumagne@intel.com>
jolivier23 added a commit that referenced this pull request May 21, 2024
@jolivier23
b/334920724 - Fix google/2.4 pylint issues (#14162)
7493780 
disable CODEOWNERS for google branch
disable upstream hardware tests on branch by default
remove bad merge block
fix ordering of imports
Rename google-changeId.py
set option for dynamic fuse

Backports included here for test fixes
DAOS-15429 test: Fix Go unit tests (#13981)
DAOS-13490 test: Update valgrind suppressions. (#13142)
DAOS-15159 test: add a supression for new valgrind warning in NLT (#13782)
DAOS-14669 test: switch tcp;ofi_rxm testing to tcp (#13365)
DAOS-15548 test: add new valgrind suppression for daos tool (#14081)

Required-githooks: true

Change-Id: Ifc50889fd7aada1ae1666ed928b7edc9293da5b7
Signed-off-by: Jeff Olivier <jeffolivier@google.com>
Signed-off-by: Michael MacDonald <mjmac@google.com>
Signed-off-by: Ashley Pittman <ashley.m.pittman@intel.com>
Signed-off-by: Mohamad Chaarawi <mohamad.chaarawi@intel.com>
Signed-off-by: Jerome Soumagne <jerome.soumagne@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashleypittman ashleypittman ashleypittman approved these changes

@knard-intel knard-intel knard-intel approved these changes

@frostedcmos frostedcmos Awaiting requested review from frostedcmos

@soumagne soumagne Awaiting requested review from soumagne

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mchaarawi @ashleypittman @knard-intel