Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-15416 test: Update memcheck suppressions. #14015

Merged
merged 1 commit into from
Mar 18, 2024
Merged

DAOS-15416 test: Update memcheck suppressions. #14015

merged 1 commit into from
Mar 18, 2024

Conversation

janekmi
Copy link
Contributor

@janekmi janekmi commented Mar 18, 2024 •
edited
Loading

On a clean build on el8.8 one of the existing suppressions needs tweaking.

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@github-actions GitHub Actions
Copy link

Bug-tracker data:
Ticket title is 'Unit Tests / NLT on EL 8.8 / NLT.core.Error - valgrind failures'
Status is 'Open'
Labels: 'NLT-testing,ci_impact,release/2.4,triaged'
https://daosio.atlassian.net/browse/DAOS-15416

@soumagne
Copy link
Collaborator

soumagne commented Mar 18, 2024 •
edited
Loading

interesting was that removed recently or is it a 2.4 thing ? just as an fyi I also have a PR there (master only currently) that is adding a few more suppressions for tcp: #13365

@soumagne
Copy link
Collaborator

Ah actually I see now, @ashleypittman #12315 was not backported then?

daosbuild1
daosbuild1 reviewed Mar 18, 2024
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@ashleypittman
Copy link
Contributor

Ah actually I see now, @ashleypittman #12315 was not backported then?

That appears to be the issue, and until now our CI systems haven't been running on the 8.8 release.

@ashleypittman
Copy link
Contributor

I think this PR is targeting the wrong branch.

@janekmi janekmi changed the base branch from v2.4 to release/2.4 March 18, 2024 17:41
@janekmi janekmi requested review from a team as code owners March 18, 2024 17:41
daosbuild1
daosbuild1 reviewed Mar 18, 2024
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@janekmi janekmi force-pushed the janekmi/DAOS-15416-fix branch from c91d1f1 to 2560b87 Compare March 18, 2024 17:45
daosbuild1
daosbuild1 reviewed Mar 18, 2024
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@mchaarawi mchaarawi merged commit 77bbf01 into release/2.4 Mar 18, 2024
32 of 34 checks passed
@mchaarawi mchaarawi deleted the janekmi/DAOS-15416-fix branch March 18, 2024 19:05
@ashleypittman @janekmi
DAOS-15416 test: Update memcheck suppressions.
2560b87 
On a clean build on el8.8 one of the existing suppressions needs
tweaking.

Signed-off-by: Ashley Pittman <ashley.m.pittman@intel.com>
Signed-off-by: Jan Michalski <jan.michalski@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daosbuild1 daosbuild1 daosbuild1 left review comments

@soumagne soumagne soumagne approved these changes

@frostedcmos frostedcmos frostedcmos approved these changes

@ashleypittman ashleypittman Awaiting requested review from ashleypittman

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@janekmi @soumagne @ashleypittman @frostedcmos @daosbuild1 @mchaarawi