Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-14845 rebuild: do not wait for EC agg for reclaim #13610

Merged
merged 1 commit into from
Jan 17, 2024
Merged

DAOS-14845 rebuild: do not wait for EC agg for reclaim #13610

merged 1 commit into from
Jan 17, 2024

Conversation

wangdi1
Copy link
Contributor

@wangdi1 wangdi1 commented Jan 15, 2024

Do not need wait for EC aggregation for reclaim operation, which does not involve fetch and update.

Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate watchers.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

DAOS-14845 rebuild: do not wait for EC agg for reclaim
2faada0 
Do not need wait for EC aggregation for reclaim operation,
which does not involve fetch and update.

Required-githooks: true

Signed-off-by: Di Wang <di.wang@intel.com>
@github-actions GitHub Actions
Copy link

Bug-tracker data:
Ticket title is 'timeout for mdtest after killing one rank FTEST_erasurecode.EcodOnlineRebuildMdtest.1-./erasurecode/online_rebuild_mdtest.py'
Status is 'In Review'
Labels: 'pr_test'
https://daosio.atlassian.net/browse/DAOS-14845

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-13610/1/testReport/

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium Verbs Provider completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13610/1/execution/node/1433/log

@wangdi1
Copy link
Contributor Author

wangdi1 commented Jan 17, 2024

failure due to DAOS-14972 and DAOS-14884

@gnailzenh gnailzenh merged commit 8599ceb into master Jan 17, 2024
44 of 48 checks passed
@gnailzenh gnailzenh deleted the wangdi/daos_14845_reclaim branch January 17, 2024 12:38
daosbuild1 pushed a commit that referenced this pull request Jan 17, 2024
DAOS-14845 rebuild: do not wait for EC agg for reclaim (#13610)
7e86ce4 
Do not need wait for EC aggregation for reclaim operation,
which does not involve fetch and update.

Signed-off-by: Di Wang <di.wang@intel.com>
jolivier23 pushed a commit that referenced this pull request Jul 2, 2024
@liuxuezhao @jolivier23
b/349170185 Backport fixes
6087823 
DAOS-16039 object: fix EC aggregation wrong peer address (#14593)
DAOS-16009 rebuild: fix O_TRUNC file size related handling
DAOS-15056 rebuild: add rpt to the rgt list properly (#13862)
DAOS-15517 rebuild: refine lock handling for rpt list (#14064)
DAOS-13812 container: fix destroy vs lookup (#12757)
DAOS-15627 dtx: redunce stack usage for DTX resync to avoid overflow (#14189)
DAOS-14845 rebuild: do not wait for EC agg for reclaim (#13610)

Signed-off-by: Xuezhao Liu <xuezhao.liu@intel.com>
Signed-off-by: Mohamad Chaarawi <mohamad.chaarawi@intel.com>
Signed-off-by: Jeff Olivier <jeffolivier@google.com>
Signed-off-by: Wang, Di <wddi218@gmail.com>
Signed-off-by: Di Wang <di.wang@intel.com>
Signed-off-by: Wang Shilong <shilong.wang@intel.com>
Signed-off-by: Fan Yong <fan.yong@intel.com>
@jolivier23 jolivier23 mentioned this pull request Jul 2, 2024
Merged
18 tasks
jolivier23 added a commit that referenced this pull request Jul 3, 2024
@jolivier23
b/349170185 Backport fixes (#14680)
5b9557b 
DAOS-16039 object: fix EC aggregation wrong peer address (#14593)
DAOS-16009 rebuild: fix O_TRUNC file size related handling
DAOS-15056 rebuild: add rpt to the rgt list properly (#13862)
DAOS-15517 rebuild: refine lock handling for rpt list (#14064)
DAOS-13812 container: fix destroy vs lookup (#12757)
DAOS-15627 dtx: redunce stack usage for DTX resync to avoid overflow (#14189)
DAOS-14845 rebuild: do not wait for EC agg for reclaim (#13610)

Signed-off-by: Xuezhao Liu <xuezhao.liu@intel.com>
Signed-off-by: Mohamad Chaarawi <mohamad.chaarawi@intel.com>
Signed-off-by: Jeff Olivier <jeffolivier@google.com>
Signed-off-by: Wang, Di <wddi218@gmail.com>
Signed-off-by: Di Wang <di.wang@intel.com>
Signed-off-by: Wang Shilong <shilong.wang@intel.com>
Signed-off-by: Fan Yong <fan.yong@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liuxuezhao liuxuezhao liuxuezhao approved these changes

@gnailzenh gnailzenh gnailzenh approved these changes

@Nasf-Fan Nasf-Fan Awaiting requested review from Nasf-Fan

@jolivier23 jolivier23 Awaiting requested review from jolivier23

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wangdi1 @daosbuild1 @liuxuezhao @gnailzenh