Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-14440 build: Update distro versions in GHA #13608

Merged
merged 2 commits into from
Jan 17, 2024
Merged

DAOS-14440 build: Update distro versions in GHA #13608

merged 2 commits into from
Jan 17, 2024

Conversation

brianjmurrell
Copy link
Contributor

@brianjmurrell brianjmurrell commented Jan 15, 2024 •
edited
Loading

The supported distro versions got missed in 56e3228 for the GitHub
Actions workflow.

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
    • Abbreviated the hardware testing as only a single hardware test run is sufficient to prove the change.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate watchers.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@brianjmurrell brianjmurrell self-assigned this Jan 15, 2024
@github-actions GitHub Actions
Copy link

Bug-tracker data:
Ticket title is 'qualify DAOS to RHEL / Rocky 8.8'
Status is 'Resolved'
Labels: 'triaged'
Job should run at elevated priority (1)
https://daosio.atlassian.net/browse/DAOS-14440

@github-actions github-actions bot added the priority Ticket has high priority (automatically managed) label Jan 15, 2024
@brianjmurrell
DAOS-14440 build: Update distro versions in GHA
38f15e5 
The supported distro versions got missed in 56e3228 for the GitHub
Actions workflow.

Run-GHA: true
Skip-unit-tests: true
Skip-func-test-leap15: false
Skip-func-hw-test-medium: true
Skip-func-hw-test-medium-verbs-provider: true
Skip-func-hw-test-medium-ucx-provider: true
Test-tag: always_passes
Allow-unstable-test: true
Skip-PR-comments: true

Required-githooks: true

Signed-off-by: Brian J. Murrell <brian.murrell@intel.com>
@brianjmurrell brianjmurrell force-pushed the bmurrell/update-gha-distro-versions branch from c03295f to 38f15e5 Compare January 15, 2024 17:59
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 15, 2024 •
edited
Loading

Functional on EL 8.8 Test Results (old)

 3 tests   3 ✅  18s ⏱️
11 suites  0 💤
11 files    0 ❌

Results for commit 1276d2f.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 15, 2024 •
edited
Loading

Functional on EL 9 Test Results (old)

 3 tests   3 ✅  24s ⏱️
11 suites  0 💤
11 files    0 ❌

Results for commit 1276d2f.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 15, 2024 •
edited
Loading

Functional on Leap 15.5 Test Results (old)

 3 tests   3 ✅  14s ⏱️
11 suites  0 💤
11 files    0 ❌

Results for commit 1276d2f.

♻️ This comment has been updated with latest results.

@brianjmurrell
Fix for unset BUILD_URL in GHA
1276d2f 
Run-GHA: true
Skip-unit-tests: true
Skip-func-test-leap15: false
Skip-func-hw-test-medium: true
Skip-func-hw-test-medium-verbs-provider: true
Skip-func-hw-test-medium-ucx-provider: true
Test-tag: always_passes
Allow-unstable-test: true
Skip-PR-comments: true

Required-githooks: true

Signed-off-by: Brian J. Murrell <brian.murrell@intel.com>
@github-actions GitHub Actions
Copy link

Functional Hardware Large Test Results (old)

52 tests   52 ✅  19s ⏱️
11 suites   0 💤
11 files     0 ❌

Results for commit 1276d2f.

@brianjmurrell brianjmurrell marked this pull request as ready for review January 15, 2024 20:55
@brianjmurrell brianjmurrell added the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label Jan 15, 2024
@brianjmurrell brianjmurrell requested a review from a team January 16, 2024 17:29
@brianjmurrell brianjmurrell mentioned this pull request Jan 16, 2024
Merged
@daltonbohning daltonbohning merged commit da658ad into master Jan 17, 2024
51 checks passed
@daltonbohning daltonbohning deleted the bmurrell/update-gha-distro-versions branch January 17, 2024 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daltonbohning daltonbohning daltonbohning approved these changes

@JohnMalmberg JohnMalmberg JohnMalmberg approved these changes

@ryon-jensen ryon-jensen ryon-jensen approved these changes

@phender phender Awaiting requested review from phender

Assignees

@brianjmurrell brianjmurrell

Labels
forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. priority Ticket has high priority (automatically managed)
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@brianjmurrell @daltonbohning @JohnMalmberg @ryon-jensen