Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-13964 build: update libfabric to 1.18.1 and apply prov/tcp patches #12704

Merged
merged 1 commit into from
Aug 3, 2023

Conversation

soumagne
Copy link
Collaborator

Patches are required to ensure thread safety of prov/tcp

Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate watchers.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

Patches are required to ensure thread safety of prov/tcp

Required-githooks: true

Signed-off-by: Jerome Soumagne <jerome.soumagne@intel.com>
@github-actions
Copy link

Bug-tracker data:
Ticket title is 'ofi+tcp having issues with dd workload over dfuse (no IL)'
Status is 'Awaiting Verification'
Labels: '2.4_in_review,required_for_ga,triaged'
Job should run at elevated priority (3)
https://daosio.atlassian.net/browse/DAOS-13964

@github-actions github-actions bot added priority Ticket has high priority (automatically managed) release-2.4 PR is eventually targeted for 2.4 labels Jul 24, 2023
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium Verbs Provider completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12704/1/execution/node/1241/log

Copy link
Contributor

@daltonbohning daltonbohning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably can remove the "and apply prov/tcp patches" part, right?

Copy link
Contributor

@mchaarawi mchaarawi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you want to add those spec file changes that you mentioned are needed for testing ofi with pr-repos tag?

@soumagne
Copy link
Collaborator Author

soumagne commented Aug 2, 2023

@daltonbohning it does apply the patches in build.config, maybe you're thinking about different patches ?

@soumagne
Copy link
Collaborator Author

soumagne commented Aug 2, 2023

@mchaarawi well I'll leave that to Brian since he was working on the issue, @daltonbohning added new PR tags also that he is working on in another PR.

@daltonbohning
Copy link
Contributor

apply prov/tcp patches" part, right

Woops. Was thinking about the other testing PR :)

@soumagne soumagne requested a review from a team August 3, 2023 14:11
@mchaarawi
Copy link
Contributor

please create 2.4 backport

@mchaarawi mchaarawi merged commit a0ef567 into master Aug 3, 2023
@mchaarawi mchaarawi deleted the soumagne/ofi118_1 branch August 3, 2023 14:44
soumagne added a commit that referenced this pull request Aug 3, 2023
…es (#12704)

Patches are required to ensure thread safety of prov/tcp

Signed-off-by: Jerome Soumagne <jerome.soumagne@intel.com>
mchaarawi pushed a commit that referenced this pull request Aug 3, 2023
…es (#12704) (#12772)

Patches are required to ensure thread safety of prov/tcp

Signed-off-by: Jerome Soumagne <jerome.soumagne@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority Ticket has high priority (automatically managed) release-2.4 PR is eventually targeted for 2.4
Development

Successfully merging this pull request may close these issues.

5 participants