-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DAOS-13964 build: update libfabric to 1.18.1 and apply prov/tcp patches #12704
Conversation
Patches are required to ensure thread safety of prov/tcp Required-githooks: true Signed-off-by: Jerome Soumagne <jerome.soumagne@intel.com>
Bug-tracker data: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. No errors found by checkpatch.
Test stage Functional Hardware Medium Verbs Provider completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12704/1/execution/node/1241/log |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably can remove the "and apply prov/tcp patches" part, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did you want to add those spec file changes that you mentioned are needed for testing ofi with pr-repos tag?
@daltonbohning it does apply the patches in build.config, maybe you're thinking about different patches ? |
@mchaarawi well I'll leave that to Brian since he was working on the issue, @daltonbohning added new PR tags also that he is working on in another PR. |
Woops. Was thinking about the other testing PR :) |
please create 2.4 backport |
…es (#12704) Patches are required to ensure thread safety of prov/tcp Signed-off-by: Jerome Soumagne <jerome.soumagne@intel.com>
Patches are required to ensure thread safety of prov/tcp
Required-githooks: true
Before requesting gatekeeper:
Features:
(orTest-tag*
) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.Gatekeeper: