Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-13883 cart: control request_post_init/incr through env vars #12565

Merged
merged 6 commits into from
Nov 30, 2023
Merged

DAOS-13883 cart: control request_post_init/incr through env vars #12565

merged 6 commits into from
Nov 30, 2023

Conversation

soumagne
Copy link
Collaborator

@soumagne soumagne commented Jun 29, 2023 •
edited
Loading

Add D_POST_INIT / D_POST_INCR env vars

This enables tuning of multi-recv buffer sizes and number of server preposted recvs when multi-recv is not enabled.

Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate watchers.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@soumagne soumagne requested a review from frostedcmos June 29, 2023 17:24
daosbuild1
daosbuild1 reviewed Jun 29, 2023
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@github-actions
Copy link

Bug-tracker data:
Ticket title is 'Add option to control size of multi-recv buffers'
Status is 'In Progress'
https://daosio.atlassian.net/browse/DAOS-13883

daosbuild1
daosbuild1 reviewed Jun 30, 2023
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@soumagne soumagne force-pushed the soumagne/init_post_limit branch from 12c8dd6 to 032b5e8 Compare June 30, 2023 16:27
daosbuild1
daosbuild1 reviewed Jun 30, 2023
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@soumagne soumagne marked this pull request as ready for review August 3, 2023 20:28
liw
liw requested changes Aug 7, 2023
View reviewed changes
src/gurt/misc.c Outdated Show resolved Hide resolved
src/cart/crt_init.c Show resolved Hide resolved
frostedcmos
frostedcmos reviewed Sep 11, 2023
View reviewed changes
src/cart/crt_init.c Outdated
@@ -68,6 +68,7 @@ dump_envariables(void)
"D_LOG_FILE", "D_LOG_FILE_APPEND_PID", "D_LOG_MASK", "DD_MASK",
"DD_STDERR", "DD_SUBSYS", "CRT_TIMEOUT", "CRT_ATTACH_INFO_PATH",
"OFI_PORT", "OFI_INTERFACE", "OFI_DOMAIN", "CRT_CREDIT_EP_CTX",
"CRT_POST_INIT", "CRT_POST_INCR",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably better to change to D_ type envariables as we were trying to get away from CRT_ prefixes

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed

@soumagne
DAOS-13883 cart: control request_post_init/incr through env vars
e4ad435 
Add D_POST_INIT / D_POST_INCR env vars

This enables tuning of multi-recv buffer sizes and number of server
preposted recvs when multi-recv is not enabled.

Required-githooks: true

Signed-off-by: Jerome Soumagne <jerome.soumagne@intel.com>
@soumagne soumagne force-pushed the soumagne/init_post_limit branch from 032b5e8 to e4ad435 Compare November 1, 2023 23:11
daosbuild1
daosbuild1 reviewed Nov 1, 2023
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@soumagne
DAOS-13883 cart: fix formatting
bd159da 
Required-githooks: true

Signed-off-by: Jerome Soumagne <jerome.soumagne@intel.com>
daosbuild1
daosbuild1 reviewed Nov 1, 2023
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@soumagne
DAOS-13883 cart: fix formatting
dbc614a 
Required-githooks: true

Signed-off-by: Jerome Soumagne <jerome.soumagne@intel.com>
@daosbuild1
Copy link
Collaborator

Test stage NLT on EL 8 completed with status FAILURE. https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-12565/4/display/redirect

daosbuild1
daosbuild1 reviewed Nov 1, 2023
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-12565/6/testReport/

@soumagne soumagne requested review from liw and frostedcmos November 6, 2023 17:48
frostedcmos
frostedcmos previously approved these changes Nov 6, 2023
View reviewed changes
liw
liw previously approved these changes Nov 7, 2023
View reviewed changes
src/cart/crt_init.c Show resolved Hide resolved
@soumagne
DAOS-13883 cart: simplify query of env vars
21566a6 
Required-githooks: true

Signed-off-by: Jerome Soumagne <jerome.soumagne@intel.com>
@soumagne soumagne dismissed stale reviews from liw and frostedcmos via 21566a6 November 7, 2023 22:15
@soumagne soumagne requested a review from liw November 7, 2023 22:15
@soumagne soumagne requested a review from frostedcmos November 7, 2023 22:15
daosbuild1
daosbuild1 reviewed Nov 7, 2023
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

frostedcmos
frostedcmos approved these changes Nov 7, 2023
View reviewed changes
Copy link
Contributor

@frostedcmos frostedcmos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks cleaner with d_getenv_int() usage:)

daosbuild1
daosbuild1 reviewed Nov 17, 2023
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium MD on SSD completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-12565/9/testReport/

daosbuild1
daosbuild1 reviewed Nov 29, 2023
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@soumagne
Copy link
Collaborator Author

Failed in https://daosio.atlassian.net/browse/DAOS-14594 (known issue)

@soumagne soumagne requested a review from a team November 30, 2023 19:17
@soumagne soumagne added the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label Nov 30, 2023
@mchaarawi mchaarawi merged commit c11b258 into master Nov 30, 2023
26 checks passed
@mchaarawi mchaarawi deleted the soumagne/init_post_limit branch November 30, 2023 20:18
soumagne added a commit that referenced this pull request Nov 30, 2023
@soumagne
DAOS-13883 cart: control request_post_init/incr through env vars (#12565
a4bb797 
)

Add D_POST_INIT / D_POST_INCR env vars

This enables tuning of multi-recv buffer sizes and number of server preposted recvs when multi-recv is not enabled.

Required-githooks: true

Signed-off-by: Jerome Soumagne <jerome.soumagne@intel.com>
mchaarawi pushed a commit that referenced this pull request Dec 5, 2023
@soumagne
DAOS-13883 cart: control request_post_init/incr through env vars (#12565
5d918d3 
) (#12566)

Add D_POST_INIT / D_POST_INCR env vars

This enables tuning of multi-recv buffer sizes and number of server preposted recvs when multi-recv is not enabled.

Signed-off-by: Jerome Soumagne <jerome.soumagne@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daosbuild1 daosbuild1 daosbuild1 left review comments

@liw liw liw approved these changes

@frostedcmos frostedcmos frostedcmos approved these changes

@liuxuezhao liuxuezhao Awaiting requested review from liuxuezhao

@jgmoore-or jgmoore-or Awaiting requested review from jgmoore-or

@mchaarawi mchaarawi Awaiting requested review from mchaarawi

Assignees
No one assigned
Labels
forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@soumagne @daosbuild1 @liw @frostedcmos @mchaarawi